Repository navigation
fix(cypher): support expression-valued pattern properties - #1027
Merged
Merged
Conversation
This was referenced Apr 2, 2026
lmeyerov
force-pushed
the
fix/issue-1000-dynamic-pattern-properties
branch
from
April 3, 2026 03:18
5baaf5e to
2a50cfc
Compare
16 of 19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
This is Phase 1 of
#1000, carved out from the umbrella draft PR#1022.What it covers:
MATCH (a)-[:R]->(b {num: a.num})MATCH (a)-[:R]->(b {num: a.num + 0})MATCH (a:A), (b:B {num: a.num})MATCH (a)-[r:R {weight: a.num}]->(b)lowering and runtimeMATCH (b {id: bid})MATCH (b)-[rel:S {score: bscore}]->(c)WHERE b.num = a.numWhat it does not cover yet:
WITHafter post-WITH MATCH WHEREUNWINDbetween reentry stagespostAmplification findings
The follow-on amplification on this branch found three additional Phase 1 bugs and fixed them here:
WHEREwhere=constraints instead of bindings-table row predicatesLinks
Testing
python3.12 -B -m pytest -q graphistry/tests/compute/gfql/cypher/test_parser.py -k 'linear_pattern_with_labels_properties_and_aliases or expression_valued_pattern_property_entry or identifier_valued_pattern_property_entry or relationship_expression_valued_pattern_property_entry'python3.12 -B -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k 'same_path_alias_comparison_where_runtime or preserves_alias_frames_for_same_path_multi_column_projection or same_path_expression_valued_pattern_property or keeps_literal_pattern_filters_alongside_dynamic_property_entries or falls_back_to_row_where_for_non_property_dynamic_pattern_expression or non_property_dynamic_pattern_expression_runtime or relationship_expression_valued_pattern_property or relationship_expression_valued_pattern_property_runtime or reentry_identifier_valued_pattern_property or reentry_relationship_expression_valued_pattern_property or cartesian_dynamic_pattern_property or cartesian_property_join_to_row_where_expression'ruff check graphistry/compute/gfql/cypher/lowering.py graphistry/tests/compute/gfql/cypher/test_parser.py graphistry/tests/compute/gfql/cypher/test_lowering.pyBenchmark status
The exact official IC6 query now gets past the original syntax failure on
t:Tag{id: knownTagId}and still stops at the next planned barrier:Cypher WITH after post-WITH MATCH WHERE is not yet supported in the current GFQL Cypher compiler