Repository navigation
Conversation
This was referenced Apr 2, 2026
lmeyerov
force-pushed
the
fix/issue-1000-multi-reentry-where
branch
from
April 3, 2026 03:18
817b253 to
36e1906
Compare
lmeyerov
force-pushed
the
fix/issue-1000-prefix-scalar-reentry
branch
from
April 3, 2026 03:18
5a5e9da to
e112f8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1000
Stacked on #1032.
This Phase 5 slice removes the old bounded-reentry requirement that the prefix WITH stage project exactly one whole-row alias. Single-row scalar-only prefix shapes like
MATCH (t) WITH t.id AS tid MATCH (p)-[:R]->(u {id: tid}) RETURN ...now compile and execute in the local Cypher compiler.What's included:
WITH ... MATCH ...support for single-row prefix shapesORDER BY/LIMITCHANGELOG.mdprepBenchmark progression:
postFocused validation run locally on April 2, 2026:
python3.12 -B -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "scalar_only_prefix_with_match_reentry or issue_1000_ic6_after_phase5_now_stops_at_reentry_comma_pattern_fanout"->8 passed, 1 skipped, 632 deselectedpython3.12 -B -m pytest -q graphistry/tests/compute/gfql/cypher/test_parser.py -k "reentry or unwind"->11 passed, 84 deselectedpython3.12 -B -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "multiple_post_with_where_clauses or scalar_only_prefix_with_match_reentry or post_with_match_collect_unwind_match or issue_1000_ic6_after_phase5_now_stops_at_reentry_comma_pattern_fanout"->17 passed, 2 skipped, 622 deselectedruff check graphistry/compute/gfql/cypher/lowering.py graphistry/compute/gfql_unified.py graphistry/tests/compute/gfql/cypher/test_lowering.py graphistry/tests/compute/gfql/cypher/test_parser.py-> passed