Repository navigation
test(gfql): pin list-column ORDER BY prefix-tie-break semantics (#1359) - #1360
Merged
Merged
Conversation
Locks in `build_list_sort_columns` openCypher-correct behavior for prefix-tied list keys: shorter list ranks before longer when prefix elements are equal (`[2, -2] < [2, -2, 100]`). Mirrors the openCypher TCK clauses/with-orderBy/WithOrderBy1.feature [31]/[32] fixture using proper Python-list values. Triage for #1353 item #1 / #1359 wrong-row tranche showed pygraphistry's list-sort is correct when given Python lists; the 14 wrong-row classifications are tck-gfql repo issues (parser stores list literals as strings; runner forces ordered comparison even when feature says "in any order"). Tracked in tck-gfql#36. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This was referenced May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_row_pipeline_order_by_list_column_matches_opencypher_prefix_tie_breaktographistry/tests/compute/gfql/test_row_pipeline_ops.py.build_list_sort_columnsopenCypher-correct behavior for prefix-tied list keys: shorter list ranks before longer when prefix elements are equal ([2, -2] < [2, -2, 100]).clauses/with-orderBy/WithOrderBy1.featurescenarios [31]/[32] using proper Python-list values.Context
Triage for #1353 item #1 / #1359 wrong-row tranche showed pygraphistry's list-sort is correct when given Python lists; the 14 wrong-row classifications are tck-gfql repo issues, tracked in tck-gfql#36:
parse_cypher.py::_parse_propertiesstores list literals as strings, so the row pipeline never sees a list-typed column._rows_orderedforces ordered comparison even when the openCypher feature says "in any order".This PR adds a defensive test so future row-pipeline work doesn't silently regress the (currently correct) list comparator + prefix-tie-break behavior. No production code change.
#1359 stays open until tck-gfql#36 lands and the contract count drops.
Test plan
pytest graphistry/tests/compute/gfql/test_row_pipeline_ops.py(178 passed, 5 skipped locally)./bin/ruff.sh graphistry/tests/compute/gfql/test_row_pipeline_ops.py