Repository navigation
fix(gfql): strict binder post-WITH UNWIND traversal order (#1371 P1) - #1384
Merged
Merged
Conversation
lmeyerov
marked this pull request as ready for review
May 9, 2026 08:33
This was referenced May 9, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FrontendBinder._bind_graph_sequencetraversal for strict binder mode so post-WITHUNWINDresolves aliases from precedingWITHclauses in source orderScope
Validation
python -m pytest -q graphistry/tests/compute/gfql/cypher/test_binder.py graphistry/tests/compute/gfql/cypher/test_binder_strict_compile_baseline.py graphistry/tests/compute/gfql/cypher/test_validator_runtime_strict_parity.pypython -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "unwind_after_with_into_post_with_match or unwind_with_carried_scalar_into_post_with_match or unwind_with_multiple_carried_scalars or distinct_unwind_with_carried_scalar or with_unwind_reentry_progresses_past_parser"./bin/ruff.sh graphistry/compute/gfql/frontends/cypher/binder.py graphistry/tests/compute/gfql/cypher/test_binder.py graphistry/tests/compute/gfql/cypher/test_binder_strict_compile_baseline.py graphistry/tests/compute/gfql/cypher/test_validator_runtime_strict_parity.py./bin/mypy.sh graphistry/compute/gfql/frontends/cypher/binder.py graphistry/tests/compute/gfql/cypher/test_binder.py