Repository navigation
fix(cypher): admit IC11 person!=friend scope through reentry prefix (#1391) - #1401
Merged
Merged
Conversation
lmeyerov
marked this pull request as ready for review
May 9, 2026 18:06
lmeyerov
force-pushed
the
issue-1391-employment-company-row-join
branch
from
May 9, 2026 21:47
a70ba03 to
16490c4
Compare
lmeyerov
force-pushed
the
issue-1391-employment-company-row-join
branch
from
May 9, 2026 22:12
623cc77 to
3722971
Compare
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the IC11/job-referral residual blocker tracked by #1391 by admitting the prefix-stage
WHERE NOT(person=friend)scope in the reentry compilation path.What changed
graphistry/compute/gfql/cypher/lowering.pyWHEREvalidation in_lower_projection_chain.WHEREexpressions.WHERE.graphistry/tests/compute/gfql/cypher/test_lowering.pyMATCH (person)-[:KNOWS*1..2]-(friend)WHERE NOT(person=friend)WITH DISTINCT friendWhy
#1391tracks an employment/company row-join residual lane (interactive-complex-11/job-referral) that still required adapter-side join workaround logic. The row join path itself already executed; the prefix compile path rejectedNOT(person=friend)after scope trimming. This patch fixes that admission gap.Validation
python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "job_referral_employment_company_row_join_shape"python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "seeded_multihop_then_with_match_reentry_shape or seeded_multihop_then_with_optional_match_reentry_shape"uv run ruff check graphistry/compute/gfql/cypher/lowering.py graphistry/tests/compute/gfql/cypher/test_lowering.pyIssue linkage