Repository navigation
GFQL/Cypher: strict runtime binder default + baseline retirement (#1357) - #1408
Merged
Merged
Conversation
lmeyerov
force-pushed
the
issue-1357-strict-default-flip
branch
from
May 10, 2026 08:54
d059547 to
e886bbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compile_cypher_query()tostrict_name_resolution=TrueCHANGELOG.mddevelopment entry for [FEA] Cypher binder: enable strict-name-resolution to centralize alias-scope enforcement #1357 strict-default flip laneCloses #1357
Validation
PYTHONPATH=. UV_CACHE_DIR=/tmp/uv-cache uv run --no-project --with pytest python -m pytest -q graphistry/tests/compute/gfql/cypher/test_binder_strict_compile_baseline.pyPYTHONPATH=. UV_CACHE_DIR=/tmp/uv-cache uv run --no-project --with pytest python -m pytest -q graphistry/tests/compute/gfql/cypher/test_validator_runtime_strict_parity.pyPYTHONPATH=. UV_CACHE_DIR=/tmp/uv-cache uv run --no-project --with pytest python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "scalar_only_prefix_alias_reused_as_node_variable"./bin/ruff.sh graphistry/compute/gfql/cypher/lowering.py graphistry/tests/compute/gfql/cypher/test_binder_strict_compile_baseline.py graphistry/tests/compute/gfql/cypher/test_validator_runtime_strict_parity.pyuv run --no-project --with mypy python -m mypy --cache-dir /tmp/mypy-cache graphistry/compute/gfql/cypher/lowering.py graphistry/tests/compute/gfql/cypher/test_binder_strict_compile_baseline.py graphistry/tests/compute/gfql/cypher/test_validator_runtime_strict_parity.py