Repository navigation
Fix #1413 IC3 carried-row reentry - #1428
Merged
Merged
Conversation
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WITH person, collect(city) AS cities MATCH ...WITHstages for the single-reentry IC3 suffixfriendCity IN citiesandNOT friendCity IN citiescollect(x)whole-row null cases in the validation-failure bucket for both directRETURNand downstreamWITHcollect(city),collect(DISTINCT city), CASE aggregation, post-aggregate filtering, TCK optional aggregate boundaries, positive same-city membership, direct collected-entity rendering, and cuDF reentry smokegraphistry/_version.pyby annotating the Versioneer handler registryValidation
PYTHONPATH=/home/lmeyerov/Work/clients/diana/varsity/.venv/lib/python3.12/site-packages python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_1413_ic3_cross_country_carried_row_collect_list_reentry_case_sum graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_1413_ic3_collect_distinct_entity_membership_with_post_aggregate_where graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_1413_ic3_entity_membership_positive_same_city_friend_only graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_1413_ic3_collect_whole_row_entities_render_after_binding_grouping graphistry/tests/compute/gfql/cypher/test_lowering.py::test_string_cypher_failfast_optional_match_collect_null_whole_row_return_boundary graphistry/tests/compute/gfql/cypher/test_lowering.py::test_string_cypher_failfast_optional_match_collect_null_whole_row_with_boundary graphistry/tests/compute/gfql/cypher/test_lowering.py::test_string_cypher_failfast_relationship_whole_row_grouped_count_star_boundary-> 7 passedPYTHONPATH=/home/lmeyerov/Work/clients/diana/varsity/.venv/lib/python3.12/site-packages python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k '(issue_1413 or optional_match_collect_null_whole_row or failfast_relationship_whole_row_grouped_count_star_boundary) and not cudf'-> 11 passedPYTHONPATH=/home/lmeyerov/Work/clients/diana/varsity/.venv/lib/python3.12/site-packages python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k 'not cudf'-> 911 passed, 88 deselectedpython3 -m ruff check graphistry/tests/compute/gfql/cypher/test_lowering.py-> passedPYTHONPATH=/home/lmeyerov/Work/clients/diana/varsity/.venv/lib/python3.12/site-packages python3 -m py_compile graphistry/tests/compute/gfql/cypher/test_lowering.py-> passedPYTHONPATH=/home/lmeyerov/Work/clients/diana/varsity/.venv/lib/python3.12/site-packages python3 bin/ci_cypher_surface_guard.py-> passedpython3 -m py_compile graphistry/_version.py-> passedpython3 -m ruff check graphistry/_version.py graphistry/tests/compute/gfql/cypher/test_lowering.py-> passedpython3 -m mypy graphistry/_version.py-> passedgit diff --check-> passedssh dgx-spark:MATRIX_CELLS="25.02:gfql 26.02:gfql" WITH_IMAGE_BUILD=0 WITH_GPU=1 WITH_LINT=0 WITH_TYPECHECK=0 WITH_TEST=1 PROFILE=gfql TEST_FILES="..." ./test-rapids-official-matrix.sh-> 25.02/gfql PASS, 26.02/gfql PASS on 8 focused testsf2b79d1b-> green, includingtck-gfql, Cypher gates, Python lint/type matrix, docs, core, pandas/polars, Spark, Neo4j, and full-ai jobsNotes
origin/masterlast checked at1520a728424fdc0c54fa507f912e3e24aa7953f7; merge-base with PR head is unchanged, so no rebase is needed.