Skip to content

[codex] Remove connected-match row-join compat fallback - #1431

Merged
lmeyerov merged 1 commit into
masterfrom
issue-1418-row-join-fallback-delete
May 15, 2026
Merged

lmeyerov merged 1 commit into
masterfrom
issue-1418-row-join-fallback-delete

Conversation

@lmeyerov

@lmeyerov lmeyerov commented May 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Refs #1418.

Conservative D1 deletion: remove the legacy connected MATCH row-join fallback branch from the compatibility executor. Connected MATCH joins now route directly from the physical-plan executor before generic same-path/row-pipeline compatibility dispatch, so they no longer re-enter the old compat executor branch.

Kept out of scope intentionally:

Validation

  • /tmp/tck-gfql-ci-venv312/bin/python -m pytest -q graphistry/tests/compute/gfql/test_runtime_physical_cutover.py
  • /tmp/tck-gfql-ci-venv312/bin/python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_1411_connected_join_property_projection_shape graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_1411_connected_join_whole_row_projection_shape
  • /tmp/tck-gfql-ci-venv312/bin/python -m pytest -q graphistry/tests/test_compute_chain.py::TestChainBindingsTable::test_issue_1411_join_apply_projects_joined_message_rows graphistry/tests/test_compute_chain.py::TestChainBindingsTable::test_issue_1411_join_apply_left_preserves_unmatched_rows
  • ./bin/ruff.sh graphistry/compute/gfql_unified.py graphistry/tests/compute/gfql/test_runtime_physical_cutover.py

No benchmark reruns were run locally.

@lmeyerov
lmeyerov force-pushed the issue-1418-row-join-fallback-delete branch from f3f628d to b828204 Compare May 14, 2026 23:42
@lmeyerov
lmeyerov merged commit 7932d9f into master May 15, 2026
137 checks passed
@lmeyerov
lmeyerov deleted the issue-1418-row-join-fallback-delete branch May 15, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant