Repository navigation
Harden cuDF to_pandas to_dict lowering tests - #1444
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1439
Summary
_to_pandas_df().to_pandas().to_dict(orient="records")and related directto_pandas()conversions fromtest_lowering.pyValidation
python3 -m py_compile graphistry/tests/compute/gfql/cypher/test_lowering.pypython3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k 'not cudf'./bin/ruff.sh graphistry/tests/compute/gfql/cypher/test_lowering.pyPROFILE=gfql TEST_FILES="graphistry/tests/compute/gfql/cypher/test_lowering.py -k cudf"->88 passedIMAGE_TAG=graphistry/test-rapids-official:26.02-cuda12-gfql PROFILE=gfql TEST_FILES="graphistry/tests/compute/gfql/cypher/test_lowering.py -k cudf"->88 passedPROFILE=gfql->343 passedPROFILE=gfql->343 passedNotes
test_lowering.pycannot complete on this shell becausecudfis installed but no CUDA-capable device is present; cuDF coverage was validated ondgx-spark../bin/typecheck.sh graphistry/tests/compute/gfql/cypher/test_lowering.pystill reports pre-existing test typing/environment issues (pyteststubs plus existing AST/Plottable annotations), not introduced helper-call failures.