Skip to content

Fix Cypher pattern predicate row expansion - #1451

Merged
lmeyerov merged 2 commits into
masterfrom
issue-1449-pattern-predicate-wrong-rows
May 15, 2026
Merged

lmeyerov merged 2 commits into
masterfrom
issue-1449-pattern-predicate-wrong-rows

Conversation

@lmeyerov

Copy link
Copy Markdown
Contributor

Summary

  • Fixes Direct-Cypher residual: pattern predicate wrong rows under #1369 #1449
  • Keeps direct-Cypher WHERE pattern predicates as existence checks instead of rewriting single positives into appended MATCH clauses
  • Adds TCK-shaped pandas/cuDF coverage for expr-pattern1-10, expr-pattern1-13, and expr-pattern1-18
  • Updates normalizer/lowering tests and changelog

Validation

  • python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k 'pattern_predicate or where_pattern or variable_length_where_pattern' -> 38 passed, 3 skipped
  • python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k 'not cudf' -> 934 passed, 12 skipped, 111 deselected
  • python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_ast_normalizer.py graphistry/tests/compute/gfql/cypher/test_parser.py -> 149 passed
  • dgx-spark RAPIDS 26.02 focused pattern predicate targets -> 16 passed
  • dgx-spark RAPIDS 25.02 focused pattern predicate targets -> 16 passed
  • review skill converged after helper-name cleanup; no remaining blocker/important findings

@lmeyerov

Copy link
Copy Markdown
Contributor Author

CI note: tck-gfql needed a matching sidecar branch for the #1449 contract rebaseline. Sidecar PR: graphistry/tck-gfql#117. Both pygraphistry tck-gfql reruns passed after the sidecar branch was pushed.

@lmeyerov
lmeyerov marked this pull request as ready for review May 15, 2026 19:24
@lmeyerov
lmeyerov force-pushed the issue-1449-pattern-predicate-wrong-rows branch from c36738a to 19c4956 Compare May 15, 2026 19:50
@lmeyerov
lmeyerov force-pushed the issue-1449-pattern-predicate-wrong-rows branch from 19c4956 to f3bc64e Compare May 15, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Direct-Cypher residual: pattern predicate wrong rows under #1369

1 participant