Skip to content

DRY cuDF/pandas lowering test factory twins - #1494

Merged
lmeyerov merged 1 commit into
masterfrom
issue-1073-dry-cudf-factory-twins
May 17, 2026
Merged

DRY cuDF/pandas lowering test factory twins#1494
lmeyerov merged 1 commit into
masterfrom
issue-1073-dry-cudf-factory-twins

Conversation

@lmeyerov

@lmeyerov lmeyerov commented May 17, 2026

Copy link
Copy Markdown
Contributor

Closes #1073.

Summary

LOC

CHANGELOG.md                                           +1 / -0
graphistry/tests/compute/gfql/cypher/test_lowering.py  +56 / -137
Total                                                   +57 / -137 = -80 LOC

Validation

Local:

git diff --check
python3 -m compileall -q graphistry/tests/compute/gfql/cypher/test_lowering.py
python3 -m ruff check graphistry/tests/compute/gfql/cypher/test_lowering.py
./bin/typecheck.sh
python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "(...touched factories...) and not cudf"
python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "not cudf"

Receipts:

  • focused non-cuDF touched factories: 16 passed
  • broader non-cuDF lowering: 943 passed, 12 skipped, 113 deselected
  • ruff/typecheck/compileall/diff-check: passed
  • local cuDF attempt: blocked by host cudaErrorNoDevice, rerun on DGX

DGX/cuDF:

ssh dgx-spark 'cd /tmp/pygraphistry-1073 && RAPIDS_VERSION=25.02 PROFILE=gfql TEST_FILES="...touched cudf tests..." ./docker/test-rapids-official-local.sh'
ssh dgx-spark 'cd /tmp/pygraphistry-1073 && RAPIDS_VERSION=26.02 PROFILE=gfql TEST_FILES="...touched cudf tests..." ./docker/test-rapids-official-local.sh'

Receipts:

  • RAPIDS 25.02: 24 passed
  • RAPIDS 26.02: 24 passed

Review protocol converged with no findings.

@lmeyerov
lmeyerov force-pushed the issue-1073-dry-cudf-factory-twins branch from d029b90 to e54722c Compare May 17, 2026 08:40
@lmeyerov
lmeyerov force-pushed the issue-1073-dry-cudf-factory-twins branch from e54722c to 251ee02 Compare May 17, 2026 17:02
@lmeyerov
lmeyerov merged commit f3e0e2b into master May 17, 2026
23 checks passed
@lmeyerov
lmeyerov deleted the issue-1073-dry-cudf-factory-twins branch May 17, 2026 17:03
This was referenced May 17, 2026
Closed
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chore(tests): DRY remaining cudf factory twins in test_lowering.py (~97 LOC)

1 participant

@lmeyerov