Repository navigation
Fix Cypher node identity column handling - #1504
Merged
Merged
Conversation
lmeyerov
force-pushed
the
issue-1490-direct-cypher-node-id
branch
from
May 17, 2026 18:11
7101e4e to
8e36200
Compare
lmeyerov
force-pushed
the
issue-1490-direct-cypher-node-id
branch
from
May 17, 2026 18:46
8e36200 to
d59d00b
Compare
This was referenced May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1490
Summary
idreferences in Cypher lowering with an internal__gfql_node_id__token.idprojectable and distinct from internal node identity.idproperty projection.Notes
tck-gfql.Validation
python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py::test_lower_match_query_rewrites_duplicate_node_aliases_to_internal_identity_checks graphistry/tests/compute/gfql/cypher/test_lowering.py::test_string_cypher_duplicate_node_alias_identity_shape_uses_bound_node_column graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_1490_repeated_node_alias_uses_bound_node_identity graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_1490_user_id_property_remains_projectable_with_custom_identity graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_1490_distinct_and_grouping_use_bound_identity_not_user_id-> 5 passedpython3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k 'issue_1490 or duplicate_node_alias or custom_node_column_name or count_distinct or grouping_use_bound_identity or whole_row_grouping'-> 13 passedpython3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k 'not cudf'-> 949 passed, 12 skipped, 113 deselected./bin/ruff.sh-> passed./bin/typecheck.sh-> passedgit diff --check-> passedpython3 bin/ci_cypher_surface_guard.py-> passed (lowering.pyat 9038/9038 baseline)PROFILE=gfql, GPU): Cypher engine hardcodesidas the node-identity column #1490 cuDF regression + two GFQL cuDF smokes -> 3 passedPROFILE=gfql, GPU): Cypher engine hardcodesidas the node-identity column #1490 cuDF regression + two GFQL cuDF smokes -> 3 passedPYTHONPATH=/home/lmeyerov/Work/pygraphistry2 python3 -m pytest -q tests/cypher_tck/test_tck_runner.py::test_direct_cypher_xfail_contract --maxfail=1-> 724 passedPYTHONPATH=/home/lmeyerov/Work/pygraphistry2 python3 -m pytest -q tests/cypher_tck/test_direct_cypher_contract_fastfail.py::test_direct_cypher_nonvalidation_outcome_snapshot_fastfail-> 1 passedPYTHONPATH=/home/lmeyerov/Work/pygraphistry2 python3 -m pytest -q tests/cypher_tck/test_report.py::test_direct_cypher_nonvalidation_samples_are_stable_and_bounded tests/cypher_tck/test_report.py::test_build_report_includes_gap_priority_sections-> 2 passedtck-gfqljobs (76419264072,76419266901)