Repository navigation
Remove residual Cypher chain fallback - #1508
Merged
Merged
Conversation
lmeyerov
force-pushed
the
issue-1486-final-fallback-deletion
branch
3 times, most recently
from
May 18, 2026 01:16
f833c06 to
5adf0e8
Compare
lmeyerov
force-pushed
the
issue-1486-final-fallback-deletion
branch
from
May 18, 2026 01:28
5adf0e8 to
fccb853
Compare
This was referenced May 18, 2026
perf: graphistry wheel size (625 kB) — GFQL engine files are large, investigate modularization
#1058
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1486.
Summary
logical_plan is Noneapproved chain-execution branch and its runtime allowlist/helpermultiple_match_stages,optional_match_reentry, and unknown defer codes no longer silently chain-executelogical_plan_defer_code/logical_plan_defer_reasoncontext keys instead of a nestedvaluepayloadCHANGELOG.mdInventory
Base after rebase:
origin/master @ f1831304The remaining
logical_plan_none_without_codeexamples are UNION programs;_execute_compiled_query()dispatchesCompiledCypherUnionQuerybefore non-union execution, so they do not reach_execute_compiled_query_non_union().Validation
python3 -m pytest -q graphistry/tests/compute/gfql/test_runtime_physical_cutover.py -k 'not cudf' graphistry/tests/compute/gfql/test_logical_planner.py graphistry/tests/compute/gfql/cypher/test_lowering.py::test_string_cypher_executes_seeded_multihop_then_with_optional_match_reentry_shape57 passed, 1 deselectedpython3 -m pytest -q graphistry/tests/compute/gfql/test_runtime_physical_cutover.py::test_non_union_execution_requires_logical_plan graphistry/tests/compute/gfql/test_runtime_physical_cutover.py::test_deferred_logical_plan_reason_rejected_before_chain_execution graphistry/tests/compute/gfql/test_runtime_physical_cutover.py::test_deferred_logical_plan_code_rejected_before_chain_execution5 passedpython3 -m pytest -q graphistry/tests/compute/gfql/test_runtime_physical_cutover.py -k 'not cudf'30 passed, 1 deselectedpython3 -m pytest -q graphistry/tests/compute/gfql -k 'not cudf'2167 passed, 29 skipped, 134 deselected, 15 xfailedpython3 -m ruff check graphistry/compute/gfql/defer_codes.py graphistry/compute/gfql/logical_planner.py graphistry/compute/gfql/cypher/lowering.py graphistry/compute/gfql_unified.py graphistry/tests/compute/gfql/test_runtime_physical_cutover.pypassed
./bin/typecheck.shSuccess: no issues found in 273 source filestest_runtime_physical_cutover.pycuDF case fails on this host before assertions withcudaErrorNoDevice; covered on DGXdgx-sparkRAPIDS 25.02 focused GFQL/cuDF runtime cutover file31 passed, 1 warning, log/tmp/issue-1486-rapids-25.02.logdgx-sparkRAPIDS 26.02 focused GFQL/cuDF runtime cutover file31 passed, log/tmp/issue-1486-rapids-26.02.logMerge
Auto-merge after DGX validation, review-skill convergence, CI green, and final master freshness check.