Skip to content

Clean up AST helpers - #1513

Merged
lmeyerov merged 2 commits into
masterfrom
codex/issue-1512-ast-helper-cleanup
May 18, 2026
Merged

lmeyerov merged 2 commits into
masterfrom
codex/issue-1512-ast-helper-cleanup

Conversation

@lmeyerov

@lmeyerov lmeyerov commented May 17, 2026 •

Copy link
Copy Markdown
Contributor

Closes #1512.
Refs #1058.

Summary

  • Removes unused internal assert_record_match() from graphistry.compute.ast.
  • Consolidates duplicated ASTEdge*from_json() common field extraction into private graphistry.compute.ast helpers.
  • Preserves existing ASTEdge, ASTEdgeForward, ASTEdgeReverse, ASTEdgeUndirected classes, aliases, constructors, and wire payload behavior.

Tests

  • python3 -m py_compile graphistry/compute/ast.py
  • python3 -m pytest -q graphistry/tests/compute/test_ast.py graphistry/tests/compute/test_ast_errors.py graphistry/tests/compute/test_chain_validation.py
  • python3 -m pytest -q tests/gfql/ref/test_chain_optimizations.py graphistry/tests/compute/test_chain.py graphistry/tests/compute/test_gfql.py -k 'json or serialization or simple_single_hop or Chain or from_json'
  • ./bin/ruff.sh graphistry/compute/ast.py graphistry/tests/compute/test_ast.py
  • ./bin/typecheck.sh graphistry/compute/ast.py
  • git diff --check

DGX/RAPIDS

  • Not run: this is pure AST JSON construction/test coverage and does not touch dataframe/cuDF execution paths.

Review Protocol

  • Review skill artifacts will be recorded under plans/issue-1512-ast-helper-cleanup/.
  • This PR should not be auto-merged.

@lmeyerov lmeyerov changed the title Refactor AST edge JSON helpers Clean up AST helpers May 18, 2026
@lmeyerov
lmeyerov force-pushed the codex/issue-1512-ast-helper-cleanup branch from d97cce5 to 5f8f422 Compare May 18, 2026 01:04
@lmeyerov
lmeyerov merged commit f183130 into master May 18, 2026
137 checks passed
@lmeyerov
lmeyerov deleted the codex/issue-1512-ast-helper-cleanup branch May 18, 2026 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GFQL cleanup: compute ast.py dead-code and node helper audit

1 participant