Skip to content

refactor(gfql): remove unused cypher lowering delegate - #1516

Merged
lmeyerov merged 1 commit into
masterfrom
refactor/cypher-lowering-dry-audit-1509
May 18, 2026
Merged

lmeyerov merged 1 commit into
masterfrom
refactor/cypher-lowering-dry-audit-1509

Conversation

@lmeyerov

@lmeyerov lmeyerov commented May 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Validation

python3 -m compileall -q \
  graphistry/compute/gfql/cypher/lowering.py \
  graphistry/compute/gfql/cypher
python3 -m pytest -q \
  graphistry/tests/compute/gfql/cypher/test_lowering_s3_split_guard.py \
  graphistry/tests/compute/gfql/cypher/test_lowering.py \
  -k "not cudf"

Result: 954 passed, 12 skipped, 115 deselected.

./bin/ruff.sh \
  graphistry/compute/gfql/cypher/lowering.py \
  graphistry/tests/compute/gfql/cypher/test_lowering_s3_split_guard.py
./bin/typecheck.sh
python3 bin/ci_cypher_surface_guard.py
git diff --check

Surface guard: lowering.py lines 8486 <= 9045.

Review Skill

  • Converged after 2 local review waves with no findings
  • Artifacts: plans/cypher-lowering-dry-audit-1509/review/final-report.md

DGX

Not run. This deletes an uncalled private delegate and does not touch dataframe execution, cuDF/pandas behavior, physical dispatch, or GPU paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GFQL cleanup: lowering.py post-reentry dead-code and helper ownership audit

1 participant