Skip to content

Add changed-line coverage hygiene gate - #1535

Merged
lmeyerov merged 1 commit into
masterfrom
codex/issue-1533-changed-line-coverage
May 19, 2026
Merged

lmeyerov merged 1 commit into
masterfrom
codex/issue-1533-changed-line-coverage

Conversation

@lmeyerov

@lmeyerov lmeyerov commented May 18, 2026 •

Copy link
Copy Markdown
Contributor

Closes #1533.

Summary

  • add bin/changed_line_coverage.py to report and gate coverage for changed executable package lines only
  • reuse coverage collected in existing CI lanes: GFQL py3.12 coverage plus the py3.14 core-test leg, without adding coverage overhead to the 5-minute minimal sentinel
  • add a PR-only combiner job that enforces an initial 80% changed-line threshold and uploads markdown/JSON reports

Validation

  • python3 -m py_compile bin/changed_line_coverage.py bin/coverage_audit.py
  • python3 -m pytest -q graphistry/tests/test_changed_line_coverage.py graphistry/tests/test_coverage_audit.py (13 passed)
  • ./bin/ruff.sh bin/changed_line_coverage.py graphistry/tests/test_changed_line_coverage.py
  • ./bin/typecheck.sh bin/changed_line_coverage.py
  • parsed .github/workflows/ci.yml with PyYAML
  • git diff --check

Notes

  • CPU CI only; no DGX/RAPIDS validation needed because this changes CI hygiene and coverage reporting, not dataframe/GPU runtime behavior.
  • Historical uncovered lines outside the PR diff remain non-blocking.
  • The 5-minute test-minimal-python sentinel remains at 5 minutes and uninstrumented; changed-line coverage waits for later parallel/downstream coverage artifacts instead.

@lmeyerov
lmeyerov force-pushed the codex/issue-1533-changed-line-coverage branch 2 times, most recently from 9358c8f to fd71ade Compare May 18, 2026 23:58
@lmeyerov
lmeyerov force-pushed the codex/issue-1533-changed-line-coverage branch from fd71ade to 6708f17 Compare May 19, 2026 00:28
@lmeyerov
lmeyerov force-pushed the codex/issue-1533-changed-line-coverage branch from 6708f17 to 8121232 Compare May 19, 2026 00:41
@lmeyerov
lmeyerov merged commit 4cfda5d into master May 19, 2026
141 checks passed
@lmeyerov
lmeyerov deleted the codex/issue-1533-changed-line-coverage branch May 19, 2026 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add changed-line coverage hygiene gate for Python PRs

1 participant