Repository navigation
feat(settings): expose public viz settings contracts - #1587
Merged
Merged
Conversation
lmeyerov
force-pushed
the
issue-1234-viz-settings-public
branch
from
May 20, 2026 21:23
829a9a9 to
7204c44
Compare
This was referenced May 20, 2026
perf: graphistry wheel size (625 kB) — GFQL engine files are large, investigate modularization
#1058
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
graphistry.viz_settingsas a public facade for canonical visualization settings key contracts.Literalkey aliases, typed payload dictionaries, and frontend contract metadata from one stable module.Refs #1234
Exported constants/types
URL_PARAM_NAMES,URL_PARAM_NAME_SET,URLParamName,URLParamsDict,KnownURLParamsDictREACT_SETTING_NAMES,REACT_SETTING_NAME_SET,ReactSettingName,ReactSettingsDict,KnownReactSettingsDictVIZ_SETTING_NAMES,VIZ_SETTING_NAME_SET,VizSettingNameAPPLY_ENCODINGS_REACT_KEYS,APPLY_ENCODINGS_REACT_KEY_SET,ApplyEncodingsReactKey,ApplyEncodingsReactSettingsDictGRAPHISTRY_FRONTEND_CONTRACT_VERSION, signature/version info helpers, and shared payload type aliasesLOC buckets
Compiler-plan surface touched
No. This is exported visualization settings typing/key metadata only. It does not touch GFQL compiler-plan semantics, route names, execution dispatch, diagnostics, schema/type-system hooks, IR metadata, remote schema hooks, or compatibility executors.
Coordination
PR #1584 is already merged. Its encode-call validation/types changes do not conflict with this settings-key facade; this PR only re-exports the existing frontend settings contract and adds
Literalkey aliases.Validation
python3 -m pytest -q graphistry/tests/test_viz_settings.py graphistry/tests/test_validate_settings.py-> 22 passed./bin/ruff.sh graphistry/viz_settings.py graphistry/tests/test_viz_settings.py graphistry/__init__.py-> passed./bin/typecheck.sh graphistry/viz_settings.py graphistry/tests/test_viz_settings.py-> passedgit diff --check-> passed