Repository navigation
fix(arrow): preserve nulls in validate autofix - #1598
Merged
Merged
Conversation
lmeyerov
force-pushed
the
issue-867-auto-coerce-arrow-review
branch
from
May 22, 2026 01:24
dc37ae7 to
eee9d39
Compare
This was referenced May 22, 2026
perf: graphistry wheel size (625 kB) — GFQL engine files are large, investigate modularization
#1058
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #867.
Summary
auto_coerceAPI.validate='autofix'/warncontract onplot(),upload(), andto_arrow().strcoercion for older pandas or nullable-string coercion failures.Design
masteralready has the right public API shape:This PR does not add
auto_coerce.validate='strict'/validate='strict-fast'continue to raiseArrowConversionError, whilevalidate='autofix'retries Arrow conversion by probing object columns and coercing only columns that fail individual Arrow conversion.Pandas autofix now prefers nullable string dtype when available so
None/missing values stay Arrow nulls. If that dtype is unavailable or fails, it falls back to the priorstrbehavior.Review / Oversight
plans/review-pr-1598/.origin/masterafter it moved to49e8dd02; final PR head iseee9d399ec4e193b34f283b55890bb8dd952cd48.Local validation
python3 -m pytest -q graphistry/tests/test_plotter.py::TestPlotterArrowConversions-> 28 passed, 6 skipped, 1 xfailed./bin/ruff.sh graphistry/PlotterBase.py graphistry/tests/test_plotter.py./bin/typecheck.sh graphistry/PlotterBase.pygit diff --checkDGX / RAPIDS
/home/lmeyerov/repos/pygraphistry-issue-867-dgxRAPIDS_VERSION=26.02 PROFILE=basic WITH_GPU=1 ... docker/test-rapids-official-local.sh_table_to_arrow(..., validate_mode='autofix')smoke passedRAPIDS_VERSION=25.02 PROFILE=basic WITH_GPU=1 ... docker/test-rapids-official-local.shcudf 25.02.02,cuml 25.02.01)cudaErrorMemoryAllocation out of memory;nvidia-smishowedVLLM::EngineCoreusing81870MiB. This PR leaves the cuDF coercion behavior on the existingstrpath, and 26.02 covers the actual cudf Arrow smoke.CI
26262954992completedsuccesson headeee9d399ec4e193b34f283b55890bb8dd952cd48.python-lint-typespy3.8-3.14,test-pandas-compatlegacy/latest/rapids-aligned,test-pandas-compat-gfqllegacy/latest,test-minimal-python,test-gfql-core,test-docs,test-core-python,test-spark,test-neo4j,test-build,changed-line-coverage, and CodeQL.Compiler-plan surface touched: no.