Skip to content

perf(gfql): eager native seed lanes record their index engagement in gfql_explain - #2040

Merged
lmeyerov merged 1 commit into
masterfrom
perf/gfql-eager-seed-lane-trace
Sep 5, 2026
Merged

perf(gfql): eager native seed lanes record their index engagement in gfql_explain#2040
lmeyerov merged 1 commit into
masterfrom
perf/gfql-eager-seed-lane-trace

Conversation

@lmeyerov

@lmeyerov lmeyerov commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Owner stipulation on #2037/#2038: the eager (pandas/cuDF) native op-list lanes served seeded shapes through the resident indexes without recording an explain step, so gfql_explain reported used_index: False for shapes the index answered while the polars lane (#2038) reports its engagement.

_single_node_rows_via_index_or_filter (both engines' node-only lane) and _seeded_typed_hop_pandas_cudf now record an indexed_traversal step (native_seed_lookup with the resolver that served, native_seeded_hop when the index branch produced the candidates). Policy off and no-index runs record nothing and keep their answers.

Pins (test_native_seed_lane_explain.py, pandas/polars/cuDF): node-only served by the property index → used_index + seam; seeded typed hop → seam + index_trace path; policy off → policy_off, no index step, same answer; no resident index → no index step.

Stacked on #2038. Related: #2027, #2033.

🤖 Generated with Claude Code

https://claude.ai/code/session_01QztW7jYsDd66e8rb8pJNQA

@lmeyerov
lmeyerov force-pushed the perf/gfql-eager-seed-lane-trace branch from 46f95a6 to d0c6880 Compare September 5, 2026 07:36
@lmeyerov
lmeyerov force-pushed the perf/gfql-polars-native-seed-resolution branch from daa7348 to 994f4bd Compare September 5, 2026 08:03
@lmeyerov
lmeyerov force-pushed the perf/gfql-eager-seed-lane-trace branch from d0c6880 to 3806647 Compare September 5, 2026 08:03
@lmeyerov lmeyerov mentioned this pull request Sep 5, 2026
Closed
@lmeyerov
lmeyerov force-pushed the perf/gfql-polars-native-seed-resolution branch from 994f4bd to 479a421 Compare September 5, 2026 08:36
@lmeyerov
lmeyerov force-pushed the perf/gfql-eager-seed-lane-trace branch from 3806647 to d0859c1 Compare September 5, 2026 08:36
@lmeyerov lmeyerov mentioned this pull request Sep 5, 2026
Merged
@lmeyerov

lmeyerov commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

READY (d0859c1): 75/75 + RTD; eager (pandas/cuDF) lanes record their index engagement in gfql_explain (owner stipulation on #2037/#2038); 18 pins on pandas/polars/cuDF. Stacked on #2038.

@lmeyerov
lmeyerov force-pushed the perf/gfql-polars-native-seed-resolution branch from 479a421 to 530afa4 Compare September 5, 2026 13:28
@lmeyerov
lmeyerov force-pushed the perf/gfql-eager-seed-lane-trace branch from d0859c1 to b32b52a Compare September 5, 2026 13:28
@lmeyerov
lmeyerov force-pushed the perf/gfql-polars-native-seed-resolution branch from 530afa4 to 059b2a8 Compare September 5, 2026 13:29
@lmeyerov
lmeyerov force-pushed the perf/gfql-eager-seed-lane-trace branch from b32b52a to a55adf6 Compare September 5, 2026 13:29
@lmeyerov
lmeyerov force-pushed the perf/gfql-polars-native-seed-resolution branch from 059b2a8 to bf46a8a Compare September 5, 2026 13:37
@lmeyerov
lmeyerov force-pushed the perf/gfql-eager-seed-lane-trace branch from a55adf6 to 033c1a7 Compare September 5, 2026 13:37
@lmeyerov
lmeyerov force-pushed the perf/gfql-polars-native-seed-resolution branch from bf46a8a to 86b7017 Compare September 5, 2026 13:42
@lmeyerov
lmeyerov force-pushed the perf/gfql-eager-seed-lane-trace branch from 033c1a7 to 2f60508 Compare September 5, 2026 13:42
@lmeyerov
lmeyerov force-pushed the perf/gfql-polars-native-seed-resolution branch from 86b7017 to 88ff625 Compare September 5, 2026 13:44
@lmeyerov
lmeyerov force-pushed the perf/gfql-eager-seed-lane-trace branch from 2f60508 to c4d2e9a Compare September 5, 2026 13:44
@lmeyerov
lmeyerov force-pushed the perf/gfql-polars-native-seed-resolution branch from 88ff625 to 6312e18 Compare September 5, 2026 14:23
@lmeyerov
lmeyerov force-pushed the perf/gfql-eager-seed-lane-trace branch from c4d2e9a to ab74105 Compare September 5, 2026 14:23
@lmeyerov
lmeyerov force-pushed the perf/gfql-polars-native-seed-resolution branch from 6312e18 to 0664c3a Compare September 5, 2026 15:42
@lmeyerov
lmeyerov force-pushed the perf/gfql-eager-seed-lane-trace branch from ab74105 to 682c072 Compare September 5, 2026 15:42
@lmeyerov
lmeyerov force-pushed the perf/gfql-polars-native-seed-resolution branch from 0664c3a to 4a80847 Compare September 5, 2026 16:33
@lmeyerov
lmeyerov force-pushed the perf/gfql-eager-seed-lane-trace branch from 682c072 to 373647f Compare September 5, 2026 16:33
@lmeyerov

lmeyerov commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

READY (373647f) — restacked on the new #2038 head after #2035 landed (patch-id identical to the previous head).

Round-003 amplification (see #2037 / #2038) ran at the #2038 head, which is this PR minus the trace records; the pandas/cuDF served tags in that probe came from spying on the fast-path entry because the eager lanes only record native_seed_lookup / native_seeded_hop with this PR. Nothing in this PR changes an answer; it adds the engagement record the owner asked for on #2037/#2038.

Receipts at 373647f

@lmeyerov
lmeyerov force-pushed the perf/gfql-polars-native-seed-resolution branch from 4a80847 to a3991bb Compare September 5, 2026 18:33
@lmeyerov
lmeyerov force-pushed the perf/gfql-eager-seed-lane-trace branch from 373647f to a5774fe Compare September 5, 2026 18:33
@lmeyerov lmeyerov mentioned this pull request Sep 5, 2026
Merged
@lmeyerov

lmeyerov commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

CI at the rebased head a5774fe (on the rebased #2038): 75/75 check-runs success (tck-gfql, changed-line coverage, polars lane, hygiene guards included). Patch-id identical to the previous head 373647f, so the GPU receipt (1331 passed, 3 failures identical to master, #2043) carries over. Ready to merge after #2038; it auto-retargets to master on that merge and I rebase it within the hour.

Base automatically changed from perf/gfql-polars-native-seed-resolution to master September 5, 2026 19:12
@lmeyerov
lmeyerov force-pushed the perf/gfql-eager-seed-lane-trace branch from a5774fe to f817f0b Compare September 5, 2026 19:18
@lmeyerov

lmeyerov commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

READY (f817f0b) — rebased onto master 8b208a6 after #2038 landed (GitHub retargeted the base; the commit was replayed onto master with an identical patch-id to a5774fe). CI on the new head: 77/77 check-runs success. Round-003 receipts (probe matrix, GPU lane, sentinel) carry over unchanged.

@lmeyerov @claude
perf(gfql): eager native seed lanes record their index engagement in …
8f82a71 
…gfql_explain

The pandas and cuDF single-node and seeded-hop lanes served through the
resident indexes without a trace step, so gfql_explain reported no
engagement for shapes the index answered. They now record the same
indexed_traversal step the polars lane does; policy off and no-index
runs record nothing and keep their answers.

Co-Authored-By: Claude Fable 5.1 <[email protected]>
Claude-Session: https://claude.ai/code/session_01QztW7jYsDd66e8rb8pJNQA
@lmeyerov
lmeyerov force-pushed the perf/gfql-eager-seed-lane-trace branch from f817f0b to 8f82a71 Compare September 5, 2026 21:12
@lmeyerov
lmeyerov merged commit 3712432 into master Sep 5, 2026
4 of 5 checks passed
@lmeyerov
lmeyerov deleted the perf/gfql-eager-seed-lane-trace branch September 5, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lmeyerov