Repository navigation
Handle whitespaces somehow #360
Description
Activity
Have you thought about making an protected/private method which deduplicates whitespace by examining the leading/trailing character to remember if it's whitespace (space or CR/LF)? Then just strip leading space character if it's a duplicate (unless indenting)? No allocation when stripping whitespace because we are using ROMs.
This change could likely be made almost entirely within
PrintContextExtensions.WriteAsyncwith an extra overload or method to support indenting. Minor changes would need to be made toWriteEncodedStringAsyncandWriteMultilineBlockStringalso so that no whitespace is stripped from within a string.Taking this a step further, if we abstract all of the formatting away from the SDLPrinter into the print context, we could add an option to print 'minimized', handled entirely by the print context. It would just strip or ignore all whitespace except where needed, detected solely by the last character printed compared with the next character to print. So "d" and "(" do not require a space between them in "field (arg: 2)", and nor does ":" and "2". So the print context might have methods such as:
- WriteToken (should not include spaces) (writes current indent if on a new line)
- WriteString (formatting for GraphQL and encapsulating quotes are done in here)
- WriteComment (adds
#) - WriteBlockString
- WriteLine
- Indent (returns IDisposable struct??)
- Unindent
I thought a little about all this. In general, an additional state in context and management of that state will be required.
@my @yourinstead of@my @yournow. It could be fixes as well checking parent node but for directives parent is always not null - it isDirectivescontainer, so actually grand parent is needed. Moreover, even after such check some tests failed (seePrinter_Should_Print_Pretty_If_Directives_Skipped). The core problem is that some arbitrary nodes can be skipped so it's not obvious how to handle whitespaces at all. General approach may be to require each node to print their leading whitespace if it should do that. Downside - it will complicate all printing code. I do not want to do that just to handle very rare cases.Originally posted by @sungam3r in #359 (comment)