Skip to content

Fix quad quote handling - #361

Merged
Shane32 merged 1 commit into
v8from
fix_quad_quotes
Oct 16, 2023
Merged

Shane32 merged 1 commit into
v8from
fix_quad_quotes

Conversation

@Shane32

@Shane32 Shane32 commented Oct 16, 2023

Copy link
Copy Markdown
Member

Quad quotes within a block string was broken for parsing, and did not print well.

So this did not parse:

"""
Testing\""""123
"""

Which should parse as

Testing""""123

And when attempting to print it, it printed this, while valid, was not ideal:

"""
Testing\"\"""123
"""

Both are fixed in this PR.

@Shane32
Shane32 requested a review from sungam3r October 16, 2023 14:33
@Shane32 Shane32 self-assigned this Oct 16, 2023
@github-actions github-actions Bot added the test Pull request that adds new or changes existing tests label Oct 16, 2023
@Shane32 Shane32 added bugfix Pull request that fixes a bug and removed test Pull request that adds new or changes existing tests labels Oct 16, 2023
@sungam3r

Copy link
Copy Markdown
Member

BlockStrings is not my strong skill. Approved.

@Shane32
Shane32 merged commit 81a05a6 into v8 Oct 16, 2023
@Shane32
Shane32 deleted the fix_quad_quotes branch October 16, 2023 16:13
@Shane32

Shane32 commented Oct 16, 2023

Copy link
Copy Markdown
Member Author

I think I wrote some of this code originally but I could be wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants