Repository navigation
Use auto properties and misc code cleanup - #398
Conversation
Shane32
left a comment
Shane32
left a comment
There was a problem hiding this comment.
Thanks for the code cleanup! We won’t be adding a .NET 8 target unless there is some benefit. As it is now, the compiled code would be identical for .NET 6 or .NET 8. So adding a target would simply increase the size of the nuget download.
|
We could change the .net analyzers to use the .net 8 analyzers so these issues are displayed even when not targeting .net 8 |
|
I was under the impression, .NET8 generates slightly better MSIL. But I diffed the IL and you are right, a few attributes are no longer compiled in, but the rest is the same. |
Likely enough the .NET 8 SDK does compile better than its predecessors, for any target. I’m not sure. I believe we are using the .NET 8 SDK for compilation. |
Shane32
changed the title
2 participants
This PR adds a .NET8 compilation target to the main library and addresses performance related warnings that came up with the new build target.
Furthermore, this PR contains a few low hanging code cleanups .