Skip to content

grpc-java fails to build against protobuf 3.21  #9220

Closed

Description

@jvolkman

What version of gRPC-Java are you using?

1.46.0

What is your environment?

Linux, Macos, protobuf v3.21

What did you expect to see?

A successful build

What did you see instead?

grpc-java fails to build:

external/io_grpc_grpc_java/compiler/src/java_plugin/cpp/java_generator.cpp:25:10: fatal error: 'google/protobuf/compiler/java/java_names.h' file not found
#include <google/protobuf/compiler/java/java_names.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Steps to reproduce the bug

Attempt to build grpc-java against protobuf 3.21

This commit in upstream protobuf renamed java_names.h to names.h, which is included by compiler/src/java_plugin/cpp/java_generator.cpp

Activity

  1. YifeiZhuang commented on May 27, 2022

    @YifeiZhuang
    Member

    protobuf needs upgrade, currently it is 3.19.2

  2. added this to the Next milestone on May 27, 2022
  3. modified the milestones: Next, 1.48 on Jun 6, 2022
  4. locked as resolved and limited conversation to collaborators on Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions