Repository navigation
servlet: introduce ServletServerBuilder.buildServlet() - #10921
Merged
Merged
Conversation
The committers listed above are authorized under a signed CLA. |
ejona86
approved these changes
Feb 16, 2024
ejona86
left a comment
Member
There was a problem hiding this comment.
Okay, in this specific case you are wanting an interceptor. You could do that "manually" with ServerInterceptors.intercept(), but I don't see a reason why things were limited to only build the adapter from the builder. So this seems beneficial in general.
larry-safran
approved these changes
Feb 16, 2024
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am trying to use gRPC in the existing Spring Boot application, servlets are registered programmatically there.
The code is supposed to look like the following: