Skip to content

sendFd shouldn't close the fd argument #150

Description

@JohnLato

I think most of the time you don't want it closed, and currently there's no way to avoid it.

Activity

  1. kazu-yamamoto commented on Dec 15, 2017

    @kazu-yamamoto
    Collaborator

    @eborden It is easy to implement this by removing closeFd from sendFd. What do you think?

  2. eborden commented on Dec 15, 2017

    @eborden
    Collaborator

    @kazu-yamamoto It is pretty typical to close the fd after sending. It isn't required or always what you want so it is probably correct to remove closeFd from sendFd. Its inclusion is more of a high level approach, which isn't really the intent in network any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions