Skip to content

Network.Socket.close hangs #326

Closed
Closed
Network.Socket.close hangs#326
Assignees
kazu-yamamoto
Labels
bug fix

Description

@basvandijk
basvandijk
opened on Jun 1, 2018

In yesodweb/wai#691 I wrote a simple program using warp that deadlocks on Network.Socket.close. Could this be a bug in network?

Activity

  1. kazu-yamamoto
    self-assigned this
    on Jun 1, 2018
  2. kazu-yamamoto
    added
    bug fix
    on Jun 1, 2018

  3. afcady commented on Jun 19, 2018

    @afcady
    afcady
    on Jun 19, 2018

    @basvandijk you must now interrupt accept before you call close. See #327 where I posted the relevant code.

  4. eborden commented on Jun 24, 2018

    @eborden
    eborden
    on Jun 24, 2018
    Collaborator

    Closing in favor of #327

  5. eborden
    closed this as completedon Jun 24, 2018

  6. basvandijk commented on Jun 24, 2018

    @basvandijk
    basvandijk
    on Jun 24, 2018
    MemberAuthor

    I just build warp-close-test against network-HEAD and the test finished successfully. I see that in network-HEAD the withMVar in accept and the modifyMVar in close are no longer there. That very likely fixed the deadlock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bug fix

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions