Skip to content

Deprecation warnings with bytestring-0.11.5; allow bytestring-0.12 #563

Description

@andreasabel

Would be good to allow bytestring-0.12. Also in the released version of network, if possible.

Deprecation warnings for memcpy:

[12 of 28] Compiling Network.Socket.Posix.CmsgHdr ( dist/build/Network/Socket/Posix/CmsgHdr.hs, dist/build/Network/Socket/Posix/CmsgHdr.o )

Network/Socket/Posix/CmsgHdr.hsc:72:9: warning: [-Wdeprecations]
    In the use of ‘memcpy’
    (imported from Data.ByteString.Internal, but defined in bytestring-0.11.5.0:Data.ByteString.Internal.Type):
    Deprecated: "Use Foreign.Marshal.Utils.copyBytes instead"
   |
72 |         memcpy dst src len
   |         ^^^^^^

Network/Socket/Posix/CmsgHdr.hsc:91:66: warning: [-Wdeprecations]
    In the use of ‘memcpy’
    (imported from Data.ByteString.Internal, but defined in bytestring-0.11.5.0:Data.ByteString.Internal.Type):
    Deprecated: "Use Foreign.Marshal.Utils.copyBytes instead"
   |
91 |     Cmsg (CmsgId lvl typ) <$> create (fromIntegral siz) (\dst -> memcpy dst src siz)
   |                                                                  ^^^^^^

Activity

  1. kazu-yamamoto commented on Jul 13, 2023

    @kazu-yamamoto
    Collaborator

    Could you send a PR?

  2. self-assigned this
    on Jul 14, 2023
  3. andreasabel commented on Jul 14, 2023

    @andreasabel
    MemberAuthor

    Done in #564.

    I tested network-3.1.4.0 with bytestring-0.12 and everything works well:

    cabal test --enable-tests --allow-newer=bytestring -c 'bytestring >= 0.12'
    

    So a revision is possible at this point. It could look like this:

      • Changed the library component's library dependency on 'bytestring'
        from >=0.10 && <0.12
        to >=0.10 && <0.13
  4. andreasabel commented on Jul 18, 2023

    @andreasabel
    MemberAuthor

    Ok, published the revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

dependenciesConcerning bounds of dependencies (Haskell ecosystem)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions