Skip to content

Why is unpackFamily deprecated? #324

Description

@chris-martin

There are a few deprecation warnings here that are missing some documentation - 2156c61 and 655e2f5 - Why are they deprecated, what's wrong with them, and what should we use instead?

In particular, I'm wondering what we'll need to do to upgrade https://github.com/ddfisher/haskell-socket-activation/blob/db6a14da89aa7a5411063303a820d7bde601e665/Network/Socket/Activation.hs#L45

Activity

  1. kazu-yamamoto commented on May 29, 2018

    @kazu-yamamoto
    Collaborator

    In 3.0, both packFamily and unpackPack still exist with the same signatures internally. So, I think we can export them in 3.0 and delete the deprecation pragmas from 2.7.

    If there are any other such APIs, please let me know. I will fix them in 2.7.0.1.

  2. chris-martin commented on May 29, 2018

    @chris-martin
    ContributorAuthor

    Thanks. The other deprecation warning I'm looking at is SocketStatus. ddfisher/haskell-socket-activation#5 (comment)

  3. kazu-yamamoto commented on May 29, 2018

    @kazu-yamamoto
    Collaborator

    The definition of Socket in 3.0 is:

    data Socket = Socket (IORef CInt) CInt {- for Show -}

    So, we will not have status of sockets.

  4. kazu-yamamoto commented on May 29, 2018

    @kazu-yamamoto
    Collaborator

    Done.
    Thank you for your report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions