Remove the "2.0.1.0 > 2.0.1" example, or clarify that this is bad #36

Activity

1. phadej commented on Oct 24, 2021

   

   phadej

   on Oct 24, 2021

   Collaborator

   More actions

   What concretely you are proposing? Adding an entry to a FAQ, https://github.com/haskell/pvp/blob/master/pvp-faq.md? That would be great.
2. andreasabel commented on Feb 6, 2022

   

   andreasabel

   on Feb 6, 2022

   Last edited by andreasabel

   MemberAuthor

   More actions

   I came across an upper bound shelly < 0.10.0 in the wild: https://hackage.haskell.org/package/c2hs-0.28.8/revisions/
   So had I released shelly as 0.10 (rather than 0.10.0 what I did) this major upgrade would have slipped through the fence.
   It seems that by analogy to decimal representation, folks naturally expect 0.10.0 == 0.10.
   If such equations would hold in general, then versions would be "omega-adic" numbers ($\sum_i a_i*\omega^{-i}$ where $i$ ranges over all natural numbers and each $a_i$ is a natural number).
   (EDIT: Less scary concept than "omega-adic" numbers: Polynomials $\sum_i a_i x^{i}$ with natural number coefficients $a_i$ and $0 \leq x < 1$.)

   Maybe cabal check should warn if there is a exclusive upper bound with trailing zeros, like < 0.10.0?

   👍React with 👍1Reacted by Simon Jakobi
3. phadej commented on Feb 6, 2022

   

   phadej

   on Feb 6, 2022

   Last edited by phadej

   Collaborator

   More actions

   Maybe cabal check should warn if there is a exclusive upper bound with trailing zeros, like < 0.10.0?

   As long as that doesn't prevents making revisions, as currently revisions cannot introduce more warnings (IIRC). Even the situation where adding < 0.10.0 like bound is not probable, it can happen (and may be caused by an accident, ignorance or spite!)

   EDIT: I.e. there should be a way to tell that if there is < 0.10.0 -like bound, I really need that trailing zero, i.e. to make cabal check not complain when it's intentional.
4. andreasabel commented on May 24, 2022

   

   andreasabel

   on May 24, 2022

   MemberAuthor

   More actions

   there should be a way to tell that if there is < 0.10.0 -like bound, I really need that trailing zero, i.e. to make cabal check not complain when it's intentional.

   If cabal check was configurable by flags to turn off individual warning classes (like GHC is), we could make a separate warning class that could be switched off in the rare cases when such a bound is intended. (Haskell CI could be extended to be able to pass such flags to cabal check.)
   (I'd rather not extend the .cabal file format with pragmas to turn off cabal check warnings.)