Swap genShortByteString for genByteArray #142

Activity

1. lehins commented on Sep 10, 2023

   

   lehins

   on Sep 10, 2023

   Contributor

   More actions

   I had the same idea the moment you released the byte-array package.

   This way we can shave off dependency on bytestring and do not impose it on our users.

   I don't think this is terribly important, in fat I'd be against it, especially considering that bytestring is one of the wired-in packages. I'd be against it because ability to generate ByteString and ShortByteString efficiently out of the box is a great feature. I've personally used it on multiple occasions, including at work (which is not gonna show up at hackage search).

   That being said, I do agree with you 100% requiring in RandomGen:

   genByteArray :: Int -> g -> (ByteArray, g)

   instead of

   random/src/System/Random/Internal.hs

   Line 183 in 632b64e

   genShortByteString :: Int -> g -> (ShortByteString, g)

   and

   uniformByteArray :: Int -> g -> m ByteArray

   instead of

   random/src/System/Random/Internal.hs

   Line 282 in 632b64e

   uniformShortByteString :: Int -> g -> m ShortByteString

   in StatefulGen

   Makes a lot of sense.

   ShortByteSring variants can just be extracted into standalone functions.
2. Shimuuar commented on Sep 10, 2023

   

   Shimuuar

   on Sep 10, 2023

   Contributor

   More actions

   +1 for switching to ByteArray. As for dropping dependency on bytestring I see no reason to do so. It's basically a part of a standard library

   🚀React with 🚀1Reacted by Alexey Kuleshevich
3. lehins

   closed this as completedin #153on Nov 26, 2023