You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Dammit, I was sure I fixed that CPP stuff. It probably happened in some PR that never got merged. Oh well, I am really glad you noticed it.
There was discussion about Random instance for Natrual in #44 I was really on the edge of not defining this instance and even closed that issue, but since you already implemented it, I am OK with it to be included. After all that is exactly what Random class is for. 👍
Let's give it a day or so for someone to object, and we can merge it if no-one speaks up.
Same comment as here: #72 (review) - I don't think we should be adding features to Random at this point. There already is a UniformRange Natural instance. If anybody wants to generate Natural values in the Word range, they can already do it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.