Skip to content

Nowhere seems to export the constructor to Storable vector #343

Description

@Boarders

It would be nice if the internal module exported everything in the various modules and made no guarantees with regards to stability.

Activity

  1. Boarders commented on Dec 22, 2020

    @Boarders
    ContributorAuthor

    More generally could we please move towards vector exporting everything somewhere. As it stands a user is not allowed to touch almost any aspect of the stream fusion framework. There is no particularly good reason for this if the relevant modules are marked unsafe and unstable.

  2. lehins commented on Dec 22, 2020

    @lehins
    Contributor

    You can already get to the internals of storable vector with unsafe to/from ForeignPtr convertors:

    Same applies to mutable vector

  3. Boarders commented on Dec 22, 2020

    @Boarders
    ContributorAuthor

    I know, but if I want to copy and edit some internal vector code for doing streaming I am forced to jump through so many hoops like this and it seems completely needless.

  4. lehins commented on Dec 22, 2020

    @lehins
    Contributor

    could we please move towards vector exporting everything somewhere.

    Could you be more specific? Almost every aspect is already exported, including the stream fusion functionality. Maybe not as directly as it seems, but it is totally usable. In other words, could you compile a list of things you'd like to get access to that aren't available right now and we should be able to get them exported from some special module. Without such list we can't do anything because "export everything" blindly is too messy of an approach, some things are really designed to be internal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions