Why is Data.Vector.Generic.New.New not a newtype? #453

Activity

1. konsumlamm commented on Feb 14, 2023

   

   konsumlamm

   on Feb 14, 2023

   ContributorAuthor

   More actions

   Apprently it was a newtype originally, but it was changed in 82fe1c9, although without explanation.
2. lehins commented on Feb 14, 2023

   

   lehins

   on Feb 14, 2023

   Contributor

   More actions

   @konsumlamm It must be a data type instead of newtype otherwise the rewrite rules will not fire. I can try add a comment later on to the definition with explanation why it must be a data type. I'll keep this ticket around to track this task of explaining in the code.

   👍React with 👍1Reacted by konsumlamm
3. konsumlamm

   changed the title [-]Make `Data.Vector.Generic.New.New` a newtype[/-] [+]Why is `Data.Vector.Generic.New.New` not a newtype?[/+] on Feb 14, 2023
4. Shimuuar

   added 3 commits that reference this issue on Sep 2, 2023

   Improve documentation for new & modify

   ...

   This issue will close once commit 685195a is merged into the 'master' branch.

   685195a

   Improve documentation for new & modify

   ...

   This issue will close once commit 197ddf6 is merged into the 'master' branch.

   197ddf6

   Improve documentation for new & modify

   ...

   This issue will close once commit c939197 is merged into the 'master' branch.

   c939197
5. Shimuuar

   closed this as completedin c939197on Sep 10, 2023