Repository navigation
Fix dropWhile performance - #146
Closed
charles-cooper wants to merge 2 commits into
Closed
charles-cooper wants to merge 2 commits into
charles-cooper wants to merge 2 commits into
Conversation
The `unstream` version results in a copy of the remainder of the vector which is rarely what you want to do. This commit uses `drop` directly after `findIndex` which results in a big speed gain if the remaining part of the vector is large. Cf. haskell#108 and haskell#141
Closed
Contributor
|
Superseded by #327 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
unstreamversion results in a copy of the remainder of the vectorwhich is rarely what you want to do. This commit uses
dropdirectlyafter
findIndexwhich results in a big speed gain if the remainingpart of the vector is large.
Cf. #108
and #141