Repository navigation
Documentation Fix: takeWhile not copy-free - #359
Merged
Merged
Conversation
Contributor
|
It is good to update documentation, but I am not really fond of the wording:
It doesn't tell us why it is not copy free and when it is. I think saying something along the line would at least give a bit of insight into reason:
|
Contributor
Author
|
Alrighty, I'm amending and force-pushing the fix. |
Since current implementation of takeWhile is not copy-free, correct the document to reflect that fact. See also: haskell#330
gksato
force-pushed
the
330-takeWhile-docChange
branch
from
January 17, 2021 20:20
5a049f0 to
63f2f6a
Compare
Contributor
Author
|
Done! |
lehins
self-requested a review
January 17, 2021 20:28
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since current implementation of takeWhile is not copy-free,
correct the document to reflect that fact.
I wasn't able to prepare the fix of #330 for this release,
so this PR clarifies the current situation.
See also: #330