undefined method 'wait_readable' for #<OpenSSL::SSL::SSLSocket:0x00007feb9ebacc00>

5.0.3 version has just been released has been released. We have bumped the version of the gem automatically since that was a patch update and then experienced a NoMethodError

undefined method `wait_readable' for #<OpenSSL::SSL::SSLSocket:0x00007feb9ebacc00>

backtrace points to: /gems/http-5.0.3/lib/http/timeout/global.rb:38:

http/lib/http/timeout/global.rb

Line 38 in 66a3af2

@socket.wait_readable(@time_left)

There is a change in that line in a following PR: #691

However in another place in a similar case the method wait_readable is called on io object not directly on socket:

http/lib/http/timeout/global.rb

Lines 83 to 84 in 66a3af2

    
           rescue IO::WaitReadable 
        
             wait_readable_or_timeout

http/lib/http/timeout/global.rb

Lines 92 to 96 in 66a3af2

    
           # Wait for a socket to become readable 
        
           def wait_readable_or_timeout 
        
             @socket.to_io.wait_readable(@time_left) 
        
             log_time 
        
           end

Fix `HTTP::Timeout::Global#connect_ssl`

I believe this should do it: #698.

It's unfortunate that this case isn't covered by the test suite.

Fix `HTTP::Timeout::Global#connect_ssl` (#698)

@lukasz-wojcik

@lukasz-wojcik can you verify this fixes the problem? If it does, I can cut another release.

@tarcieri

@tarcieri we had the same issue and just deployed master branch and it's fixed, from our perspective you're good to cut a new release.

From what I have checked the PR fixes this particular exception. Thx

Released in v5.0.4

Navigation Menu

Repository navigation

undefined method 'wait_readable' for #<OpenSSL::SSL::SSLSocket:0x00007feb9ebacc00> #697

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	# Wait for a socket to become readable
	def wait_readable_or_timeout
	@socket.to_io.wait_readable(@time_left)
	log_time
	end

undefined method 'wait_readable' for #<OpenSSL::SSL::SSLSocket:0x00007feb9ebacc00> #697

Description

Activity

tarcieri commented on Oct 7, 2021

tarcieri commented on Oct 7, 2021

ollym commented on Oct 7, 2021

lukasz-wojcik commented on Oct 7, 2021

tarcieri commented on Oct 7, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions