Repository navigation
Add test cases for succeed on no cache and api errors for --all - #1
Merged
iamazeem merged 1 commit intoFeb 6, 2025
Conversation
Owner
|
@jtmcg: Thank you for adding tests! 🥇 Checked this out locally. Here's the index a9ec88de..57ecb938 100644
--- a/pkg/cmd/cache/delete/delete_test.go
+++ b/pkg/cmd/cache/delete/delete_test.go
@@ -217,7 +217,7 @@ func TestDeleteRun(t *testing.T) {
},
{
name: "no caches to delete when deleting all",
- opts: DeleteOptions{Identifier: "123", DeleteAll: true},
+ opts: DeleteOptions{DeleteAll: true},
stubs: func(reg *httpmock.Registry) {
reg.Register(
httpmock.REST("GET", "repos/OWNER/REPO/actions/caches"),
@@ -233,7 +233,7 @@ func TestDeleteRun(t *testing.T) {
},
{
name: "no caches to delete when deleting all but succeed on no cache tty",
- opts: DeleteOptions{Identifier: "123", DeleteAll: true, SucceedOnNoCaches: true},
+ opts: DeleteOptions{DeleteAll: true, SucceedOnNoCaches: true},
stubs: func(reg *httpmock.Registry) {
reg.Register(
httpmock.REST("GET", "repos/OWNER/REPO/actions/caches"),
@@ -249,7 +249,7 @@ func TestDeleteRun(t *testing.T) {
},
{
name: "no caches to delete when deleting all but succeed on no cache non-tty",
- opts: DeleteOptions{Identifier: "123", DeleteAll: true, SucceedOnNoCaches: true},
+ opts: DeleteOptions{DeleteAll: true, SucceedOnNoCaches: true},
stubs: func(reg *httpmock.Registry) {
reg.Register(
httpmock.REST("GET", "repos/OWNER/REPO/actions/caches"),
@@ -261,7 +261,7 @@ func TestDeleteRun(t *testing.T) {
},
tty: false,
wantErr: false,
- wantStdout: "",
+ wantStdout: "✓ No caches to delete\n",
},
} |
Author
|
Great! You'll either have to merge this yourself (I don't have permissions) or update the existing PR to contain these tests. This will merge directly into that PR's branch, so it should be quite easy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added unit tests to TestDeleteRun to cover the following scenarios:
--succeed-on-no-cacheflag is set--succeed-on-no-cacheflag is setNote
The first test is in response to this comment on the original PR. I figured if it was enough to cause confusion before, we might as well write a test to cover it here.
The last test is currently failing and will need to be fixed before the original PR can be merged.