Skip to content

Ensure release package includes Windows SampSharp.pdb artifact - #571

Merged
ikkentim merged 4 commits into
mainfrom
copilot/include-sampsharp-pdb-release
May 16, 2026
Merged

Ensure release package includes Windows SampSharp.pdb artifact#571
ikkentim merged 4 commits into
mainfrom
copilot/include-sampsharp-pdb-release

Conversation

Copilot AI commented May 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

open.mp components already produce PDBs correctly during Windows builds, and CI artifacts include them. The missing piece was release packaging: SampSharp.pdb was not copied into the final release ZIP.

This change fixes the release workflow to include the Windows PDB in the packaged artifacts.

  • Release packaging fix (GitHub Actions)

    • Updated .github/workflows/release.yml to copy component-windows/SampSharp.pdb into SampSharp-${VERSION}/components/ during package creation.
    • Keeps behavior aligned with expectations from CI artifacts and open.mp component releases.

  • Scope correction

    • Reverted the prior CMake-based PDB output directory adjustment in src/sampsharp-component/CMakeLists.txt.
    • No component build output path changes are required for this issue.
- name: Create release package
  run: |
    mkdir -p SampSharp-${{ env.VERSION }}/components
    cp component-windows/SampSharp.dll SampSharp-${{ env.VERSION }}/components/
    cp component-windows/SampSharp.pdb SampSharp-${{ env.VERSION }}/components/
    cp component-linux/SampSharp.so SampSharp-${{ env.VERSION }}/components/SampSharp.so
    zip -r SampSharp-${{ env.VERSION }}.zip SampSharp-${{ env.VERSION }}/

Copilot AI linked an issue May 15, 2026 that may be closed by this pull request
Include SampSharp.pdb with the component release #568
Closed
Copilot AI changed the title [WIP] Add SampSharp.pdb to component release for better debugging Ensure Windows component publish includes SampSharp.pdb in release artifacts May 15, 2026
Copilot AI requested a review from ikkentim May 15, 2026 19:16
ikkentim
ikkentim reviewed May 16, 2026
View reviewed changes
Comment thread src/sampsharp-component/CMakeLists.txt Outdated
set_target_properties(SampSharp PROPERTIES OUTPUT_NAME "SampSharp" PREFIX "")
set_property(TARGET SampSharp PROPERTY MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")

if(MSVC)

@ikkentim ikkentim May 16, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot, as i understand it, our windows build script runs clang not msvc

Copilot AI May 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to apply the PDB output directory settings on WIN32 instead of MSVC, so the Windows ClangCL build path is covered as well. Addressed in commit fe3f9d5.

Copilot AI requested a review from ikkentim May 16, 2026 09:29
@ikkentim

ikkentim commented May 16, 2026

Copy link
Copy Markdown
Owner

@copilot this is wrong approach. cmake produces pdb correctly, in CI workflow it gets included, but in release workflow the pdb is not copied to the release package

@ikkentim
ikkentim marked this pull request as ready for review May 16, 2026 09:35

Copilot AI commented May 16, 2026

Copy link
Copy Markdown
Contributor Author

@copilot this is wrong approach. cmake produces pdb correctly, in CI workflow it gets included, but in release workflow the pdb is not copied to the release package

Adjusted in 87ea9fa: I reverted the CMake PDB-output change and fixed the release workflow packaging step to copy component-windows/SampSharp.pdb into the release zip (.github/workflows/release.yml).

@ikkentim
ikkentim merged commit 4c123ea into main May 16, 2026
@ikkentim
ikkentim deleted the copilot/include-sampsharp-pdb-release branch May 16, 2026 09:36
Copilot AI restored the copilot/include-sampsharp-pdb-release branch May 16, 2026 09:36
Copilot AI changed the title Ensure Windows component publish includes SampSharp.pdb in release artifacts Ensure release package includes Windows SampSharp.pdb artifact May 16, 2026
Copilot stopped work on behalf of ikkentim due to an error May 16, 2026 09:36
The session was cancelled by the user.
Copilot AI requested a review from ikkentim May 16, 2026 09:36
@ikkentim
ikkentim deleted the copilot/include-sampsharp-pdb-release branch May 25, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikkentim ikkentim Awaiting requested review from ikkentim

Assignees

@ikkentim ikkentim

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Include SampSharp.pdb with the component release

2 participants

@ikkentim