Skip to content

Fix SampSharp.EcsGameMode.OpenMp template startup signature and remove redundant usings - #583

Merged
ikkentim merged 2 commits into
mainfrom
copilot/fix-sampsharp-ecs-gamemode-template
May 20, 2026
Merged

ikkentim merged 2 commits into
mainfrom
copilot/fix-sampsharp-ecs-gamemode-template

Conversation

Copilot AI commented May 20, 2026 •

Copy link
Copy Markdown
Contributor

The SampSharp.EcsGameMode.OpenMp template drifted from the current IEcsStartup contract after IConfiguration was added to ConfigureServices, causing generated projects to fail to compile. This updates the template to match the interface and trims template-level usings that are now provided implicitly by SampSharp.Sdk.

  • Template API alignment

    • Updated template Startup to implement the current IEcsStartup signature:
      • ConfigureServices(IServiceCollection services, IConfiguration configuration)
    • Added using Microsoft.Extensions.Configuration in template Startup.cs.
  • Template using cleanup (SDK implicit usings)

    • Removed explicit SampSharp.Entities* usings from:
      • Startup.cs
      • MyFirstComponent.cs
      • MyFirstSystem.cs
    • Kept only usings still required explicitly by template source.
public class Startup : IEcsStartup
{
    public void ConfigureServices(IServiceCollection services, IConfiguration configuration)
    {
    }
}

Copilot AI changed the title [WIP] Fix compilation issue in SampSharp.EcsGameMode template Fix SampSharp.EcsGameMode.OpenMp template startup signature and remove redundant usings May 20, 2026
Copilot AI requested a review from ikkentim May 20, 2026 21:52
@ikkentim
ikkentim marked this pull request as ready for review May 20, 2026 21:53
@ikkentim
ikkentim merged commit b826511 into main May 20, 2026
1 check passed
@ikkentim
ikkentim deleted the copilot/fix-sampsharp-ecs-gamemode-template branch May 20, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Template SampSharp.EcsGameMode.OpenMp does not compile

2 participants