Repository navigation
Fix SampSharp.EcsGameMode.OpenMp template startup signature and remove redundant usings - #583
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/ikkentim/SampSharp/sessions/d7596038-9af4-46d8-b1e1-1162ee75bd24 Co-authored-by: ikkentim <[email protected]>
Copilot
AI
changed the title
[WIP] Fix compilation issue in SampSharp.EcsGameMode template
Fix May 20, 2026
SampSharp.EcsGameMode.OpenMp template startup signature and remove redundant usings
ikkentim
marked this pull request as ready for review
May 20, 2026 21:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SampSharp.EcsGameMode.OpenMptemplate drifted from the currentIEcsStartupcontract afterIConfigurationwas added toConfigureServices, causing generated projects to fail to compile. This updates the template to match the interface and trims template-level usings that are now provided implicitly bySampSharp.Sdk.Template API alignment
Startupto implement the currentIEcsStartupsignature:ConfigureServices(IServiceCollection services, IConfiguration configuration)using Microsoft.Extensions.Configurationin templateStartup.cs.Template using cleanup (SDK implicit usings)
SampSharp.Entities*usings from:Startup.csMyFirstComponent.csMyFirstSystem.cs