Repository navigation
Export UCRTVersion and UniversalCRTSdkDir - #30
Merged
Merged
Conversation
ilammy
approved these changes
Mar 17, 2021
ilammy
left a comment
ilammy
left a comment
Owner
There was a problem hiding this comment.
Uh... Sure, why not.
Thank you for noticing this, @triplef!
(I guess I should look into making a diff of the environment before and after running vcvarsall, then exporting everything that changed. That should make this explicit list of variables unnecessary.)
Contributor
Author
|
Thanks for the merge! I also found this overview of the VS variables helpful: |
Owner
|
Whoa, that's a nice analysis! |
This was referenced Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are required to build some components from the Swift toolchain (see actions/runner-images#1652 (comment)). Would be great if they could be exported.