Repository navigation
Print the error message from the environment configuration scripts at once - #41
Merged
ilammy merged 2 commits intoMay 26, 2021
Merged
Conversation
Printing them line by line will generate a bunch of error messages on the summary page of GitHub Actions workflow. I think it's a bit annoying. Note that this change will also affect the format of the final output error message, but no information will be lost.
ilammy
self-requested a review
May 26, 2021 11:58
ilammy
approved these changes
May 26, 2021
ilammy
left a comment
ilammy
left a comment
Owner
There was a problem hiding this comment.
Makes sense 👍
The change needs some rebasing on the latest master, but otherwise looks good.
Contributor
Author
|
Oh no, I did a wrong conflict resolution. |
pzhlkj6612
marked this pull request as draft
May 26, 2021 13:00
pzhlkj6612
marked this pull request as ready for review
May 26, 2021 13:10
Contributor
Author
|
Thank you for editing the text content. It should be collapsed by default. And I'm sorry I didn't make the progress smooth, please squash all the commits into one commit to avoid an ugly history. |
ilammy
approved these changes
May 26, 2021
Owner
|
@pzhlkj6612, no worries. As long as it applies cleanly, it's good. I more or less default to squash-merging anyway unless there is a particular reason to do otherwise. Thank you for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are two examples to show the difference before and after this change.
Example 1
Parameters
Comparison of GHA summary
Before
After
Comparison of GHA log
Before
After
Example 2
Parameters
Comparison of GHA summary
Before
As you can see, they are too many. And I have no idea why "Could not setup Developer Command Prompt: invalid parameters" is not here.
After
Comparison of GHA log
Before
After