Repository navigation
Add support for VS2022 - #48
Merged
Merged
Conversation
pzhlkj6612
suggested changes
Oct 6, 2021
Comment on lines
+37
to
+48
| for (const prog_files of PROGRAM_FILES) { | ||
| for (const ver of VERSIONS) { | ||
| for (const ed of EDITIONS) { | ||
| path = `${prog_files}\\Microsoft Visual Studio\\${ver}\\${ed}\\VC\\Auxiliary\\Build\\vcvarsall.bat` | ||
| core.info(`Trying standard location: ${path}`) | ||
| if (fs.existsSync(path)) { | ||
| core.info(`Found standard location: ${path}`) | ||
| return path | ||
| } | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Hi, please follow the original rule of indentation.
Suggested change
| for (const prog_files of PROGRAM_FILES) { | |
| for (const ver of VERSIONS) { | |
| for (const ed of EDITIONS) { | |
| path = `${prog_files}\\Microsoft Visual Studio\\${ver}\\${ed}\\VC\\Auxiliary\\Build\\vcvarsall.bat` | |
| core.info(`Trying standard location: ${path}`) | |
| if (fs.existsSync(path)) { | |
| core.info(`Found standard location: ${path}`) | |
| return path | |
| } | |
| } | |
| } | |
| } | |
| for (const prog_files of PROGRAM_FILES) { | |
| for (const ver of VERSIONS) { | |
| for (const ed of EDITIONS) { | |
| path = `${prog_files}\\Microsoft Visual Studio\\${ver}\\${ed}\\VC\\Auxiliary\\Build\\vcvarsall.bat` | |
| core.info(`Trying standard location: ${path}`) | |
| if (fs.existsSync(path)) { | |
| core.info(`Found standard location: ${path}`) | |
| return path | |
| } | |
| } | |
| } | |
| } |
Contributor
Author
|
Sorry about that, I think I fixed it. 2 spaces per indent. |
Contributor
Well, not really. The original is 4 spaces per indent... 🤪 In addition, just now, you could have applied my suggestion on GitHub without submitting a new commit manually. See Incorporating feedback in your pull request - GitHub Docs. |
Owner
|
Thanks! Both of you ❤️ |
ilammy
approved these changes
Oct 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows support of VS2022, it adds the check to programfiles in addition to programfilesx86