feat: support tls by NguyenHoangSon96 · Pull Request #948 · influxdata/influxdb-client-java

NguyenHoangSon96 · 2026-09-28T17:08:34Z

Closes #947

Proposed Changes

Add support for config TLS/mTLS options.
Current support is only .cert, .crt, .key files or .p12, pfx, files.
Users can choose to use a single file with both cert and key in it or separate them out into two different files .crt/.cert and .key files.
Examples are added in the "influxdb-client-java / examples / src / main / java / example / TlsExample.java" file.

Checklist

CHANGELOG.md updated
Rebased/mergeable
A test has been added if appropriate
mvn test completes successfully
Commit messages are conventional
Sign CLA (if not already signed)

codecov-commenter · 2026-09-29T08:32:41Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 38.26087% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.93%. Comparing base (fe48dfe) to head (f47cd1a).

Files with missing lines	Patch %	Lines
...ils/src/main/java/com/influxdb/utils/TlsUtils.java	0.00%	68 Missing ⚠️
...ava/com/influxdb/client/InfluxDBClientOptions.java	93.61%	1 Missing and 2 partials ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #948      +/-   ##
============================================
- Coverage     88.71%   87.93%   -0.79%     
- Complexity      735      736       +1     
============================================
  Files           174      175       +1     
  Lines          7285     7400     +115     
  Branches        422      437      +15     
============================================
+ Hits           6463     6507      +44     
- Misses          688      757      +69     
- Partials        134      136       +2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Copilot review overview

🟡 Changes recommended

The TLS loader rejects common valid key and store configurations, while the committed certificates expire in 2027.

Review effort: Balanced
Findings: 4 · 2

Open (6)

Hard-coded RSA factory rejects EC private keys · New
Password fallback prevents loading passwordless PKCS#12 files · New
Password is ignored for encrypted private keys · New
PEM CA certificates are rejected by filename extension · New
Server test certificates expire after 365 days · New
Client test certificate expires after 365 days · New

What changed in this PR

Adds custom TLS and mutual-TLS configuration for the Java client.

Changes:

Adds PEM and PKCS#12 certificate configuration.
Builds custom SSL contexts for OkHttp.
Adds TLS fixtures and integration tests.

File	Description
`pom.xml`	Excludes TLS fixtures from license checks.
`CHANGELOG.md`	Announces TLS/mTLS support.
`client-utils/.../TlsUtils.java`	Loads certificates and builds TLS managers.
`client/.../InfluxDBClientOptions.java`	Exposes TLS builder options.
`client/.../InfluxDBClientTest.java`	Tests TLS and mTLS handshakes.
`client/.../InfluxDBClientOptionsTest.java`	Tests TLS option configuration.
`client-core/.../RestClientTest.java`	Reorders imports.
`client/.../tls/generate-self-signed-cert.sh`	Generates test credentials.
`client/.../tls/influxdb.{crt,key,p12}`	Provides server fixtures.
`client/.../tls/other-server.{crt,key,p12}`	Provides untrusted-server fixtures.
`client/.../tls/client.{crt,key,p12}`	Provides client fixtures.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

Copilot review overview

🟡 Changes recommended

TLS configuration does not satisfy combined-file and plain-HTTP requirements, and PEM certificate chains are truncated.

Review effort: Balanced
Findings: 4 · 1

Open (5)

Preserve the full client certificate chain · New
Load all certificates from the PEM trust bundle · New
Support combined certificate and private-key PEM files · New
Apply TLS options only for HTTPS URLs · New
Use standard “mTLS” capitalization · New

Resolved since last review (6)

PEM CA certificates are rejected by filename extension
Password is ignored for encrypted private keys
Password fallback prevents loading passwordless PKCS#12 files
Hard-coded RSA factory rejects EC private keys
Client test certificate expires after 365 days
Server test certificates expire after 365 days

Copilot

Copilot review overview

🟡 Changes recommended

Combined PEM configuration is missing and non-RSA private-key fallback is broken.

Review effort: Balanced
Findings: 1

Open (1)

Continue key-spec fallback after RSA generation failure · New

Resolved since last review (5)

Apply TLS options only for HTTPS URLs
Support combined certificate and private-key PEM files
Load all certificates from the PEM trust bundle
Preserve the full client certificate chain
Use standard “mTLS” capitalization

Copilot

Copilot review overview

🔵 Needs a closer look

The required combined certificate/private-key file configuration is not supported.

Review effort: Balanced
Findings: None

Resolved since last review (1)

Continue key-spec fallback after RSA generation failure

Copilot

Copilot review overview

🟡 Changes recommended

Combined certificate/key files are unsupported, required paths are not validated, and the example silently uses HTTP.

Review effort: Balanced
Findings: 2

Open (2)

Validate required certificate path before configuring mTLS · New
HTTP URL bypasses TLS configuration · New

NguyenHoangSon96 self-assigned this Sep 28, 2026

NguyenHoangSon96 force-pushed the feat/support-tls branch from 73fd6c3 to 7c780a6 Compare September 29, 2026 08:21

NguyenHoangSon96 requested a balanced review from Copilot September 29, 2026 08:39

Copilot started reviewing on behalf of NguyenHoangSon96 September 29, 2026 08:40 View session

Copilot AI reviewed Sep 29, 2026

View reviewed changes

NguyenHoangSon96 force-pushed the feat/support-tls branch from 9d4caf7 to 0d4faec Compare September 29, 2026 10:18

NguyenHoangSon96 requested a balanced review from Copilot September 29, 2026 14:09

Copilot started reviewing on behalf of NguyenHoangSon96 September 29, 2026 14:10 View session

Copilot AI reviewed Sep 29, 2026

View reviewed changes

NguyenHoangSon96 force-pushed the feat/support-tls branch from a8f9b53 to c9fbd2f Compare September 30, 2026 06:40

NguyenHoangSon96 requested a balanced review from Copilot September 30, 2026 06:56

Copilot started reviewing on behalf of NguyenHoangSon96 September 30, 2026 06:56 View session

Copilot AI reviewed Sep 30, 2026

View reviewed changes

Comment thread client-utils/src/main/java/com/influxdb/utils/TlsUtils.java Outdated

NguyenHoangSon96 force-pushed the feat/support-tls branch from b89500f to e76d259 Compare September 30, 2026 07:05

NguyenHoangSon96 requested a balanced review from Copilot September 30, 2026 07:08

Copilot started reviewing on behalf of NguyenHoangSon96 September 30, 2026 07:09 View session

Copilot AI reviewed Sep 30, 2026

View reviewed changes

NguyenHoangSon96 marked this pull request as ready for review September 30, 2026 07:17

NguyenHoangSon96 requested review from alespour and karel-rehor September 30, 2026 07:59

NguyenHoangSon96 marked this pull request as draft October 7, 2026 06:32

NguyenHoangSon96 removed request for alespour and karel-rehor October 7, 2026 06:32

feat: support tls

d9501f7

NguyenHoangSon96 force-pushed the feat/support-tls branch from 77d2ae5 to d9501f7 Compare October 7, 2026 07:26

NguyenHoangSon96 requested a balanced review from Copilot October 7, 2026 07:34

Copilot started reviewing on behalf of NguyenHoangSon96 October 7, 2026 07:34 View session

Copilot AI reviewed Oct 7, 2026

View reviewed changes

Comment thread client/src/main/java/com/influxdb/client/InfluxDBClientOptions.java

Comment thread examples/src/main/java/example/TlsExample.java Outdated

feat: support tls

f47cd1a

NguyenHoangSon96 marked this pull request as ready for review October 7, 2026 07:49

NguyenHoangSon96 requested review from alespour and karel-rehor October 7, 2026 07:56

Conversation

NguyenHoangSon96 commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Checklist

Uh oh!

codecov-commenter commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NguyenHoangSon96 commented Sep 28, 2026 •

edited

Loading

codecov-commenter commented Sep 29, 2026 •

edited

Loading