Skip to content

[XPTI] Added new class xpti::framework::tracepoint_t - #4462

Merged
romanovvlad merged 2 commits into
intel:syclfrom
tovinkere:xpti_tracepoint
Sep 5, 2021
Merged

[XPTI] Added new class xpti::framework::tracepoint_t#4462
romanovvlad merged 2 commits into
intel:syclfrom
tovinkere:xpti_tracepoint

Conversation

@tovinkere

@tovinkere tovinkere commented Sep 2, 2021

Copy link
Copy Markdown
Contributor
  • Supports the creation of universal IDs and posting
    them to TLS storage. Public entry points will need
    to use the new approach to propagate Universal IDs
    through multiple layers of the SW Stack.
  • Added tests to ensure the correctness of new APIs
    to support this feature and the functionality of
    the tracepoint object.
  • New methods added to the spec:
    • xptiRegisterPayload
    • xptiQueryPayloadByUID

Signed-off-by: Vasanth Tovinkere [email protected]

@tovinkere
[XPTI] Added new class xpti::framework::tracepoint_t
a484603 
+ Supports the creation of universal IDs and posting
  them to TLS storage. Public entry points will need
  to use the new approach to propagate Universal IDs
  through multiple layers of the SW Stack.
+ Added tests to ensure the correctness of new APIs
  to support this feature and the functionality of
  the tracepoint object.
+ New methods added to the spec:
  - xptiRegisterPayload
  - xptiQueryPayloadByUID

Signed-off-by: Vasanth Tovinkere <[email protected]>
alexbatashev
alexbatashev previously approved these changes Sep 2, 2021
View reviewed changes

@alexbatashev alexbatashev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexbatashev

alexbatashev commented Sep 4, 2021

Copy link
Copy Markdown
Contributor

Jenkins job failure is not related to this patch. @bader @romanovvlad could you please take a look and help merging?

@alexbatashev alexbatashev mentioned this pull request Sep 4, 2021
Merged
@romanovvlad

romanovvlad commented Sep 5, 2021

Copy link
Copy Markdown
Contributor

Reduction/reduction_nd_s1_rw.cpp is a known issue. Merging.
@v-klochkov FYI.

@romanovvlad
romanovvlad merged commit e61dcc6 into intel:sycl Sep 5, 2021
@v-klochkov

v-klochkov commented Sep 7, 2021

Copy link
Copy Markdown
Contributor

Reduction/reduction_nd_s1_rw.cpp is a known issue. Merging.
@v-klochkov FYI.

Yes, that is a known issue. The test passes all test cases and SegFaults at exit from 'int main'. It is level_zero:gpu specific and the issue is being investigated by GPU RT team.
stack during the SegFault:
(gdb) bt
#0 0x0000000000000000 in ?? ()
#1 0x000014a9cc106b36 in ?? () from < path >/libze_intel_gpu.so.1
#2 0x000014a9cc0fc9b2 in ?? () from < path >/libze_intel_gpu.so.1
#3 0x000014a9cc130f98 in ?? () from < path >/libze_intel_gpu.so.1
#4 0x000014a9cf4cd609 in start_thread (arg=) at pthread_create.c:477
#5 0x000014a9cf61d293 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

@tovinkere
tovinkere deleted the xpti_tracepoint branch April 19, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andykaylor andykaylor Awaiting requested review from andykaylor
1 more reviewer
@alexbatashev alexbatashev alexbatashev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tovinkere @alexbatashev @romanovvlad @v-klochkov