Repository navigation
Initial draft of data flow pipes extension proposal, and move files into pipes subfolder - #635
Merged
Merged
Conversation
mkinsner
force-pushed
the
pipes_extension
branch
from
September 13, 2019 13:31
55eea5e to
78f1b51
Compare
Contributor
|
There was also #318 related to this. |
keryell
reviewed
Sep 17, 2019
keryell
left a comment
keryell
left a comment
Contributor
There was a problem hiding this comment.
Great proposal!
Here is my review on the first half of the proposal.
keryell
suggested changes
Sep 18, 2019
keryell
left a comment
keryell
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the great proposal.
That looks good on my side, just with a few typos to fix.
The most important point for me is to stream-line the map/unmap API.
Contributor
mkinsner
force-pushed
the
pipes_extension
branch
from
November 13, 2019 15:21
78f1b51 to
6290310
Compare
added 2 commits
November 13, 2019 10:30
…nto pipes subfolder. Signed-off-by: Michael Kinsner <[email protected]>
Signed-off-by: Michael Kinsner <[email protected]>
mkinsner
force-pushed
the
pipes_extension
branch
from
November 13, 2019 15:31
6290310 to
589224c
Compare
Signed-off-by: Michael Kinsner <[email protected]>
Author
Author
|
@bader I believe that this extension revision is ready to merge. |
Contributor
Author
keryell
suggested changes
Nov 14, 2019
Signed-off-by: Michael Kinsner <[email protected]>
Contributor
|
Just one nit: |
Signed-off-by: Michael Kinsner <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.