Repository navigation
fix indentation error with starting comment - #14721
Merged
Merged
Conversation
closes ipython#14242 Signed-off-by: Florian Maurer <[email protected]>
maurerle
force-pushed
the
fix_comment_start
branch
from
February 4, 2025 21:57
b0d90d4 to
2d3f2c6
Compare
Contributor
Author
|
I don't understand why darker does not like my formatting which is the same as the rest of the file.. |
Member
Don't worry about that. |
Member
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #14242
This happens when executing something like:
for some reason this is treated wrongly.
We have to explicitly check for starting # here.
Checking for multiline comments or single line strings with ' or " is not needed as cpython does not render such input valid as well.
I also experimented with some regex like this:
^[ \t]+(?=[^'"#\t ])to check for existance of #, ' or ", though I don't think this is helpful here.The issue is especially weird, as the typical error message is
while the error is in the first line..