Repository navigation
Allow scheme to be selectable in libsecret and SecretService backends - #586
Merged
Merged
Conversation
jaraco
commented
Aug 5, 2022
jaraco
commented
Owner
- Add support for a scheme property in SecretService backend. Set to 'KeypassXC' to use the username/system convention from KeypassXC, either with KEYRING_PROPERTY_SCHEME or keyring.with_properties(scheme='KeypassXC'). Fixes Using python-keyring with KeePassXC #448.
- Add test for with_properties helper.
- Re-use with_properties in with_keychain.
- Deprecate macOS.Keyring.with_keychain, superseded by with_properties.
- Extract SchemeSelectable mixin
- Allow _query to include other keys
- Add SelectableScheme to libsecret.
- Add tests for SchemeSelectable.
…eypassXC' to use the username/system convention from KeypassXC, either with KEYRING_PROPERTY_SCHEME or keyring.with_properties(scheme='KeypassXC'). Fixes #448.
mitya57
approved these changes
Aug 6, 2022
mitya57
requested changes
Aug 7, 2022
| scheme = 'default' | ||
| schemes = dict( | ||
| default=dict(username='username', service='service'), | ||
| KeypassXC=dict(username='UserName', service='Title'), |
Collaborator
There was a problem hiding this comment.
It should be KeePassXC (with e instead of y):
Please update it in all other places too.
Owner
Author
|
Released as 23.8.0. |
Collaborator
|
I am sorry for not testing it earlier, but libsecret backend does not work :( Submitted #587. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.