Skip to content

Fixed : Pages with tags not run when new FitNesse is started. - #42

Merged
jaruzafa merged 1 commit into
jenkinsci:masterfrom
suratdas:bugfix/tag-not-run-fix
Jan 16, 2022
Merged

jaruzafa merged 1 commit into
jenkinsci:masterfrom
suratdas:bugfix/tag-not-run-fix

Conversation

@suratdas

@suratdas suratdas commented Jan 13, 2022 •

Copy link
Copy Markdown
Contributor

Steps to reproduce the issue


With this plugin, select to start FitNesse and try to run a page with tags. e.g. TestSuite&runTestsMatchingAnyTag=smoke,critical The build will fail (see screenshot below).

DoesNotRunWhenTagsAdded

Why it fails and what the fix is


    The code checks to see if the FitNesse is up and running before it appends the suite responder. Because the URL includes &, it results in 404 from the FitNesse server causing the build to terminate.

    With this pull request, the base page now strips the & part to check FitNesse status resulting in a successful build.

Checks


  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@suratdas suratdas changed the title Fixed tags not run when new FitNesse is started. Fixed : Pages with tags not run when new FitNesse is started. Jan 14, 2022
@jaruzafa

Copy link
Copy Markdown
Contributor

Thanks @suratdas! , actually this is a fix for https://issues.jenkins.io/browse/JENKINS-67171
Merging it

@jaruzafa
jaruzafa merged commit 86684fc into jenkinsci:master Jan 16, 2022
@suratdas
suratdas deleted the bugfix/tag-not-run-fix branch January 16, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants