SqlStreamStore: Rebase on FeedSource - #131
Merged
Merged
Conversation
bartelink
force-pushed
the
sqlstreamstore-feed
branch
from
December 6, 2021 10:11
0b1e470 to
d2eca52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original impl of
Propulsion.SqlStreamStorewas extracted from this project.Here we come full circle and rebase the implementation on that, removing lots of code.
Aside from there being less code to go wrong/have to understand, the key benefit is that it's now wired for metrics.