Skip to content

Propulsion.Tool: Add support for Cosmos Autoscaling - #142

Merged
bartelink merged 6 commits into
jet:masterfrom
brihadish:propulsion-tool-cosmos-autoscale
May 27, 2022
Merged

bartelink merged 6 commits into
jet:masterfrom
brihadish:propulsion-tool-cosmos-autoscale

Conversation

@brihadish

Copy link
Copy Markdown
Contributor

Adds an --autoscale/-A switch to the propulsion tool to support autoscaling throughput of Cosmos containers and databases. Specifying this flag causes the --rus parameter to be interpreted as "Maximum RU/s" and changes the default value to 4000 RU/s (the minimum MaxRUs value allowed by Cosmos).

The hardcoding which existed in 'Equinox.CosmosStore.Core.Initialization.initAux' to enforce a default behavior of 'Manual throughput with 400 RU/s' has been brought into the propulsion tool.

…caling throughput of Cosmos containers and databases. Specifying this flag causes the --rus parameter to be interpreted as "Maximum RU/s" and changes the default value to 4000 RU/s (the minimum MaxRUs value allowed by Cosmos).

The hardcoding which existed in 'Equinox.CosmosStore.Core.Initialization.initAux' to enforce a default behavior of 'Manual throughput with 400 RU/s' has been brought into the propulsion tool.
Comment thread tools/Propulsion.Tool/Program.fs Outdated
Comment thread tools/Propulsion.Tool/Program.fs Outdated
Comment thread tools/Propulsion.Tool/Program.fs Outdated
Comment thread tools/Propulsion.Tool/Program.fs Outdated
@bartelink

bartelink commented May 27, 2022

Copy link
Copy Markdown
Collaborator

Did some cleanup on the stuff I cited as being good to copy, sorry 😊 !
cleaned up code: jet/equinox@1e67dfa ☺️
underlying nuget has been released, 🙏 @deviousasti https://www.nuget.org/packages/Equinox.CosmosStore/4.0.0-beta.6

brihadish added 2 commits May 27, 2022 23:45
…collection initialization in autoscale mode.

Propulsion tool change recorded in CHANGELOG.md.
@brihadish
brihadish requested a review from bartelink May 27, 2022 18:38
Comment thread tools/Propulsion.Tool/Program.fs Outdated
@brihadish
brihadish marked this pull request as ready for review May 27, 2022 19:13
@brihadish

Copy link
Copy Markdown
Contributor Author

Thanks for review. I have pushed fixes pertaining to all the comments.

@brihadish
brihadish requested a review from bartelink May 27, 2022 19:14

@bartelink bartelink left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM
Let me know when you're happy and I'll get it into the outbox

@brihadish

Copy link
Copy Markdown
Contributor Author

I have tested the changes a few times and its working. We can proceed with the merge.

@bartelink
bartelink merged commit 4aa793e into jet:master May 27, 2022
@bartelink

Copy link
Copy Markdown
Collaborator

Thanks for your contribution! Will ping when it hits nuget (will be 2.13.0-beta.7)
(And if you're looking at my cleanup, it aint nothing compared to the churn I did in jet/equinox@f1e9148 - its amazing the little things you learn about structuring Argu stuff over time...)

@bartelink

Copy link
Copy Markdown
Collaborator

@brihadish

Copy link
Copy Markdown
Contributor Author

Thank you for helping with the change :). Designing CLI tool is an art and your churn is a proof :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants